From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Wey-Yi Guy <wey-yi.w.guy@intel.com>
Subject: [RFC] skb truesize last offenders
Date: Fri, 23 Mar 2012 05:51:52 -0700 [thread overview]
Message-ID: <1332507112.4858.12.camel@edumazet-laptop> (raw)
iwlwifi and some other users of skb_add_rx_frag() lie about skb
truesize, because of API being lazy.
iwlwifi can use order-0 or order-1 pages and skb truesize is wrong.
network sbs can use uncharged kernel memory and eventually crash machine
in OOM.
I plan :
1) adding a @truesize parameter to skb_add_rx_frag() in a neutral patch
2) fix drivers that dont charge the real size of fragment
3) niu could then use skb_add_rx_frag() instead of custom code.
next reply other threads:[~2012-03-23 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 12:51 Eric Dumazet [this message]
2012-03-23 18:38 ` [RFC] skb truesize last offenders David Miller
2012-03-23 18:55 ` Eric Dumazet
2012-03-24 0:05 ` [PATCH] iwlwifi: fix skb truesize underestimation Eric Dumazet
2012-03-24 0:22 ` Eric Dumazet
2012-03-24 0:29 ` [PATCH v2] " Eric Dumazet
2012-03-24 15:35 ` Guy, Wey-Yi
2012-03-24 16:12 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332507112.4858.12.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox