From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, wey-yi.w.guy@intel.com,
Neal Cardwell <ncardwell@google.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] iwlwifi: fix skb truesize underestimation
Date: Fri, 23 Mar 2012 17:22:25 -0700 [thread overview]
Message-ID: <1332548545.2516.134.camel@edumazet-glaptop> (raw)
In-Reply-To: <1332547547.2516.132.camel@edumazet-glaptop>
On Fri, 2012-03-23 at 17:05 -0700, Eric Dumazet wrote:
> + if (len) {
> + int offset = (void *)hdr + hdrlen - rxb_addr(rxb);
> +
> + skb_add_rx_frag(skb, 0, rxb_steal_page(rxb), offset,
> + len, rxb->truesize);
> + }
> iwl_update_stats(priv, false, fc, len);
>
Please delete this patch, I'll send a v2 : iwl_update_stats() should be
called with original "len", not "len - hdrlen"
next prev parent reply other threads:[~2012-03-24 0:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 12:51 [RFC] skb truesize last offenders Eric Dumazet
2012-03-23 18:38 ` David Miller
2012-03-23 18:55 ` Eric Dumazet
2012-03-24 0:05 ` [PATCH] iwlwifi: fix skb truesize underestimation Eric Dumazet
2012-03-24 0:22 ` Eric Dumazet [this message]
2012-03-24 0:29 ` [PATCH v2] " Eric Dumazet
2012-03-24 15:35 ` Guy, Wey-Yi
2012-03-24 16:12 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332548545.2516.134.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linville@tuxdriver.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox