From: Eric Dumazet <eric.dumazet@gmail.com>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Roland Dreier <roland@purestorage.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
Oren Duer <oren@mellanox.com>,
Amir Vadai <amirv@dev.mellanox.co.il>,
John Fastabend <john.r.fastabend@intel.com>,
Amir Vadai <amirv@mellanox.com>
Subject: Re: [PATCH V3 0/6] net/mlx4_en: DCB QoS support
Date: Thu, 29 Mar 2012 05:14:06 +0200 [thread overview]
Message-ID: <1332990846.3402.5.camel@edumazet-laptop> (raw)
In-Reply-To: <CAJZOPZLLJdQX4i_WhV8Bo5UHaxndFDwf873n8ZTCPqXq7JrMiw@mail.gmail.com>
Le jeudi 29 mars 2012 à 00:21 +0200, Or Gerlitz a écrit :
> For the ratelimit Eric D. provided feedback and it was implemented
> along his suggestion,
My suggestion was exactly the following :
/sys/class/net/eth2/qos/0/ratelimit
...
/sys/class/net/eth2/qos/7/ratelimit
> and now John and Ben have other suggestions,
I dont think so.
Amir provided in V2 something that was not what I suggested.
/sys/class/net/eth2/ratelimit/tc0
...
/sys/class/net/eth2/ratelimit/tc7
And this is where John, Ben were complaining.
[ Obviously I totally agree with them ]
next prev parent reply other threads:[~2012-03-29 3:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 15:09 [PATCH V3 0/6] net/mlx4_en: DCB QoS support Amir Vadai
2012-03-27 15:09 ` [PATCH V3 1/6] net/mlx4_en: Force user priority by QP attribute Amir Vadai
2012-03-27 15:09 ` [PATCH V3 2/6] net/mlx4_core: set port QoS attributes Amir Vadai
2012-03-27 15:09 ` [PATCH V3 3/6] net/mlx4_en: DCB QoS support Amir Vadai
2012-03-27 15:09 ` [PATCH V3 4/6] net/mlx4_en: sk_prio <=> UP for untagged traffic Amir Vadai
2012-03-27 15:09 ` [PATCH V3 5/6] net/route: export symbol ip_tos2prio Amir Vadai
2012-03-27 15:09 ` [PATCH V3 6/6] IB/rdma_cm: TOS <=> UP mapping for IBoE Amir Vadai
2012-03-28 22:21 ` [PATCH V3 0/6] net/mlx4_en: DCB QoS support Or Gerlitz
2012-03-28 23:23 ` David Miller
2012-03-29 3:14 ` Eric Dumazet [this message]
2012-03-29 12:33 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332990846.3402.5.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=amirv@dev.mellanox.co.il \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=oren@mellanox.com \
--cc=roland@purestorage.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox