* [PATCH] drivers/net/wireless/libertas/if_usb.c: add missing debugging code
@ 2012-04-16 15:44 Julia Lawall
2012-04-16 16:20 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2012-04-16 15:44 UTC (permalink / raw)
To: Dan Williams
Cc: kernel-janitors, John W. Linville, libertas-dev, linux-wireless,
netdev, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Add a corresponding leave call on error failure.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/wireless/libertas/if_usb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/libertas/if_usb.c b/drivers/net/wireless/libertas/if_usb.c
index 74da5f1..ce4938d 100644
--- a/drivers/net/wireless/libertas/if_usb.c
+++ b/drivers/net/wireless/libertas/if_usb.c
@@ -1128,8 +1128,10 @@ static int if_usb_suspend(struct usb_interface *intf, pm_message_t message)
lbs_deb_enter(LBS_DEB_USB);
- if (priv->psstate != PS_STATE_FULL_POWER)
- return -1;
+ if (priv->psstate != PS_STATE_FULL_POWER) {
+ ret = -1;
+ goto out;
+ }
#ifdef CONFIG_OLPC
if (machine_is_olpc()) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/net/wireless/libertas/if_usb.c: add missing debugging code
2012-04-16 15:44 [PATCH] drivers/net/wireless/libertas/if_usb.c: add missing debugging code Julia Lawall
@ 2012-04-16 16:20 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2012-04-16 16:20 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, John W. Linville, libertas-dev, linux-wireless,
netdev, linux-kernel
On Mon, 2012-04-16 at 17:44 +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Add a corresponding leave call on error failure.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Dan Williams <dcbw@redhat.com>
>
> ---
> drivers/net/wireless/libertas/if_usb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/if_usb.c b/drivers/net/wireless/libertas/if_usb.c
> index 74da5f1..ce4938d 100644
> --- a/drivers/net/wireless/libertas/if_usb.c
> +++ b/drivers/net/wireless/libertas/if_usb.c
> @@ -1128,8 +1128,10 @@ static int if_usb_suspend(struct usb_interface *intf, pm_message_t message)
>
> lbs_deb_enter(LBS_DEB_USB);
>
> - if (priv->psstate != PS_STATE_FULL_POWER)
> - return -1;
> + if (priv->psstate != PS_STATE_FULL_POWER) {
> + ret = -1;
> + goto out;
> + }
>
> #ifdef CONFIG_OLPC
> if (machine_is_olpc()) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-16 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-16 15:44 [PATCH] drivers/net/wireless/libertas/if_usb.c: add missing debugging code Julia Lawall
2012-04-16 16:20 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox