From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: [PATCH] net: skb_free_datagram_locked() consumes skb
Date: Mon, 23 Apr 2012 10:09:27 +0200 [thread overview]
Message-ID: <1335168567.3293.20.camel@edumazet-glaptop> (raw)
From: Eric Dumazet <edumazet@google.com>
All skb_free_datagram_locked() callers consume skb, not drop it.
Noticed on dropwatch session polluted by UDP false positives.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/core/datagram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/datagram.c b/net/core/datagram.c
index ae6acf6..402c964 100644
--- a/net/core/datagram.c
+++ b/net/core/datagram.c
@@ -248,7 +248,7 @@ void skb_free_datagram_locked(struct sock *sk, struct sk_buff *skb)
unlock_sock_fast(sk, slow);
/* skb is now orphaned, can be freed outside of locked section */
- trace_kfree_skb(skb, skb_free_datagram_locked);
+ trace_consume_skb(skb);
__kfree_skb(skb);
}
EXPORT_SYMBOL(skb_free_datagram_locked);
next reply other threads:[~2012-04-23 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 8:09 Eric Dumazet [this message]
2012-04-24 4:40 ` [PATCH] net: skb_free_datagram_locked() consumes skb David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335168567.3293.20.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox