* [PATCH] net: skb_free_datagram_locked() consumes skb
@ 2012-04-23 8:09 Eric Dumazet
2012-04-24 4:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2012-04-23 8:09 UTC (permalink / raw)
To: David Miller; +Cc: netdev
From: Eric Dumazet <edumazet@google.com>
All skb_free_datagram_locked() callers consume skb, not drop it.
Noticed on dropwatch session polluted by UDP false positives.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/core/datagram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/datagram.c b/net/core/datagram.c
index ae6acf6..402c964 100644
--- a/net/core/datagram.c
+++ b/net/core/datagram.c
@@ -248,7 +248,7 @@ void skb_free_datagram_locked(struct sock *sk, struct sk_buff *skb)
unlock_sock_fast(sk, slow);
/* skb is now orphaned, can be freed outside of locked section */
- trace_kfree_skb(skb, skb_free_datagram_locked);
+ trace_consume_skb(skb);
__kfree_skb(skb);
}
EXPORT_SYMBOL(skb_free_datagram_locked);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-24 4:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-23 8:09 [PATCH] net: skb_free_datagram_locked() consumes skb Eric Dumazet
2012-04-24 4:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox