From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: ilpo.jarvinen@helsinki.fi, rick.jones2@hp.com,
netdev@vger.kernel.org, therbert@google.com,
ncardwell@google.com, maze@google.com, ycheng@google.com
Subject: Re: [RFC] allow skb->head to point/alias to first skb frag
Date: Thu, 26 Apr 2012 11:10:02 +0200 [thread overview]
Message-ID: <1335431402.2775.24.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120426.043623.1317043382565428400.davem@davemloft.net>
On Thu, 2012-04-26 at 04:36 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 26 Apr 2012 10:10:54 +0200
>
> > Idea would have :
> >
> > 1) struct sk_buff
> > 2) skb->head points to frag (aliasing, no memory allocation)
> > 3) frag of 2048 (or PAGE_SIZE/2 or PAGE_SIZE)
>
> What would you set skb->data_len and skb->len to?
>
> How would you handle tailroom? We have the rule that you can't append
> to the tail of a fragmented SKB (I mean append, the way that IPSEC
> wants to write data to the end of an SKB when encrypting, for
> example). This is only allowed on fully linear SKBs.
>
> So, for this reason and others, you can't pretend that this new
> construction is linear in any way. It would break a bunch of things.
The 'frag' would have a known size : 2048 bytes
But the end of it would be used by struct skb_shared_info
so data_len would be 0 in fact.
This would look like a regular linear skb.
Just a bit set in skb to say : Warning, skb->head was not kmalloced :
replace kfree(head) by put_page(...)
And this bit would be tested in GRO or tcp merge to 'upgrade' this
skb->head to proper page/frag
next prev parent reply other threads:[~2012-04-26 9:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 9:38 [PATCH 2/2 net-next] tcp: sk_add_backlog() is too agressive for TCP Eric Dumazet
2012-04-23 17:14 ` Rick Jones
2012-04-23 17:23 ` Eric Dumazet
2012-04-23 20:01 ` David Miller
2012-04-23 20:37 ` Eric Dumazet
2012-04-23 20:57 ` Rick Jones
2012-04-23 21:30 ` Eric Dumazet
2012-04-23 21:51 ` Rick Jones
2012-04-23 21:56 ` Rick Jones
2012-04-23 22:05 ` Eric Dumazet
2012-04-23 22:16 ` Rick Jones
2012-04-24 15:25 ` Christoph Lameter
2012-04-23 21:01 ` David Miller
2012-04-23 21:38 ` Eric Dumazet
2012-04-24 2:20 ` Eric Dumazet
2012-04-24 2:27 ` David Miller
2012-04-24 8:01 ` Ilpo Järvinen
2012-04-24 8:10 ` David Miller
2012-04-24 8:21 ` Ilpo Järvinen
2012-04-24 8:25 ` David Miller
2012-04-24 8:40 ` Ilpo Järvinen
2012-04-24 8:48 ` David Miller
2012-04-24 10:32 ` Ilpo Järvinen
2012-04-24 8:56 ` Eric Dumazet
2012-04-26 8:10 ` [RFC] allow skb->head to point/alias to first skb frag Eric Dumazet
2012-04-26 8:36 ` David Miller
2012-04-26 9:10 ` Eric Dumazet [this message]
2012-04-26 9:18 ` David Miller
2012-04-26 9:22 ` Eric Dumazet
2012-04-26 10:09 ` Maciej Żenczykowski
2012-04-26 12:32 ` Eric Dumazet
2012-04-26 13:50 ` Eric Dumazet
2012-04-26 20:12 ` David Miller
2012-04-26 20:18 ` Eric Dumazet
2012-04-24 8:49 ` [PATCH 2/2 net-next] tcp: sk_add_backlog() is too agressive for TCP Eric Dumazet
2012-04-24 8:44 ` David Laight
2012-04-24 8:53 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335431402.2775.24.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=maze@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=therbert@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox