From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"Dave Taht" <dave.taht@bufferbloat.net>,
"Kathleen Nichols" <nichols@pollere.com>,
"Van Jacobson" <van@pollere.net>,
"Tom Herbert" <therbert@google.com>,
"Matt Mathis" <mattmathis@google.com>,
"Yuchung Cheng" <ycheng@google.com>,
"Stephen Hemminger" <shemminger@vyatta.com>,
"Maciej Żenczykowski" <maze@google.com>,
"Nandita Dukkipati" <nanditad@google.com>
Subject: Re: [PATCH v2 net-next] fq_codel: Fair Queue Codel AQM
Date: Sat, 12 May 2012 00:16:16 +0200 [thread overview]
Message-ID: <1336774576.31653.289.camel@edumazet-glaptop> (raw)
In-Reply-To: <1336764650.31653.277.camel@edumazet-glaptop>
On Fri, 2012-05-11 at 21:30 +0200, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
...
> +static int fq_codel_dump_class_stats(struct Qdisc *sch, unsigned long cl,
> + struct gnet_dump *d)
> +{
> + struct fq_codel_sched_data *q = qdisc_priv(sch);
> + u32 idx = cl - 1;
> + struct gnet_stats_queue qs = { 0 };
> + struct tc_fq_codel_xstats xstats;
> +
> + WARN_ON_ONCE(1);
> + if (idx < q->flows_cnt) {
> + const struct fq_codel_flow *flow = &q->flows[idx];
> + const struct sk_buff *skb = flow->head;
Oh well, I forgot to remove this WARN_ON_ONCE(1)
next prev parent reply other threads:[~2012-05-11 22:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 13:59 [PATCH net-next] fq_codel: Fair Queue Codel AQM Eric Dumazet
2012-05-11 15:03 ` Changli Gao
2012-05-11 15:23 ` Eric Dumazet
2012-05-11 16:08 ` Eric Dumazet
2012-05-11 18:49 ` pch_gbe oops with vlan Andy Cress
2012-05-11 20:36 ` David Miller
2012-05-11 19:30 ` [PATCH v2 net-next] fq_codel: Fair Queue Codel AQM Eric Dumazet
2012-05-11 19:49 ` [PATCH v2 iproute2] " Eric Dumazet
2012-05-11 22:16 ` Eric Dumazet [this message]
2012-05-11 22:17 ` [PATCH v2 net-next] " David Miller
2012-05-12 19:55 ` David Miller
2012-05-12 20:42 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336774576.31653.289.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=dave.taht@bufferbloat.net \
--cc=davem@davemloft.net \
--cc=mattmathis@google.com \
--cc=maze@google.com \
--cc=nanditad@google.com \
--cc=netdev@vger.kernel.org \
--cc=nichols@pollere.com \
--cc=shemminger@vyatta.com \
--cc=therbert@google.com \
--cc=van@pollere.net \
--cc=xiaosuo@gmail.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox