From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: xiaosuo@gmail.com, netdev@vger.kernel.org,
dave.taht@bufferbloat.net, nichols@pollere.com, van@pollere.net,
therbert@google.com, mattmathis@google.com, ycheng@google.com,
shemminger@vyatta.com, maze@google.com, nanditad@google.com
Subject: Re: [PATCH v2 net-next] fq_codel: Fair Queue Codel AQM
Date: Sat, 12 May 2012 22:42:37 +0200 [thread overview]
Message-ID: <1336855357.31653.1331.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120512.155555.1011024268184559052.davem@davemloft.net>
On Sat, 2012-05-12 at 15:55 -0400, David Miller wrote:
> I applied this with the WARN_ON_ONCE(1) removed but there was another
> problem.
>
> When you include ping output in your commit message that "---" string
> told GIT that this was the end of the commit message when in fact
> there was more content including your signoff.
>
> I caught it and fixed it up, but please be more mindful of this in
> the future.
Oops... I feel sorry and I fear this will happen again, because I use a
lot "ping". I'll try to remember this.
Thanks a lot David.
prev parent reply other threads:[~2012-05-12 20:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 13:59 [PATCH net-next] fq_codel: Fair Queue Codel AQM Eric Dumazet
2012-05-11 15:03 ` Changli Gao
2012-05-11 15:23 ` Eric Dumazet
2012-05-11 16:08 ` Eric Dumazet
2012-05-11 18:49 ` pch_gbe oops with vlan Andy Cress
2012-05-11 20:36 ` David Miller
2012-05-11 19:30 ` [PATCH v2 net-next] fq_codel: Fair Queue Codel AQM Eric Dumazet
2012-05-11 19:49 ` [PATCH v2 iproute2] " Eric Dumazet
2012-05-11 22:16 ` [PATCH v2 net-next] " Eric Dumazet
2012-05-11 22:17 ` David Miller
2012-05-12 19:55 ` David Miller
2012-05-12 20:42 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336855357.31653.1331.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=dave.taht@bufferbloat.net \
--cc=davem@davemloft.net \
--cc=mattmathis@google.com \
--cc=maze@google.com \
--cc=nanditad@google.com \
--cc=netdev@vger.kernel.org \
--cc=nichols@pollere.com \
--cc=shemminger@vyatta.com \
--cc=therbert@google.com \
--cc=van@pollere.net \
--cc=xiaosuo@gmail.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox