public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexandru Copot <alex.mihai.c@gmail.com>
Cc: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
	netdev@vger.kernel.org, Daniel Baluta <dbaluta@ixiacom.com>,
	Lucian Grijincu <lucian.grijincu@gmail.com>
Subject: Re: [RFC PATCH 0/4] inet: add second hash table
Date: Wed, 30 May 2012 09:57:20 +0200	[thread overview]
Message-ID: <1338364640.2760.96.camel@edumazet-glaptop> (raw)
In-Reply-To: <1338363410-6562-1-git-send-email-alex.mihai.c@gmail.com>

On Wed, 2012-05-30 at 10:36 +0300, Alexandru Copot wrote:
> This patchset implements all the operations needed to use a second
> (port,address) bind hash table for inet. It uses a similar approach
> as the UDP implementation.
> 
> The performance improvements for port allocation are very good and
> detailed in the last message.
> 
> This is based on a series of patches written by Lucian Grijincu at Ixia.
> 
> Signed-off-by: Alexandru Copot <alex.mihai.c@gmail.com>
> Cc: Daniel Baluta <dbaluta@ixiacom.com>
> Cc: Lucian Grijincu <lucian.grijincu@gmail.com>
> ---
> Alexandru Copot (4):
>       inet: add counter to inet_bind_hashbucket
>       inet: add a second bind hash
>       inet: add/remove inet buckets in the second bind hash
>       inet: use second hash in inet_csk_get_port
> 
>  include/net/inet_hashtables.h    |  140 +++++++++++++++++++++++++++++++--
>  include/net/inet_timewait_sock.h |    5 +-
>  net/dccp/proto.c                 |   37 ++++++++-
>  net/ipv4/inet_connection_sock.c  |   66 ++++++++--------
>  net/ipv4/inet_hashtables.c       |  158 ++++++++++++++++++++++++++++++++++++--
>  net/ipv4/inet_timewait_sock.c    |   16 ++--
>  net/ipv4/tcp.c                   |   17 ++++
>  net/ipv6/inet6_hashtables.c      |   95 +++++++++++++++++++++++
>  8 files changed, 477 insertions(+), 57 deletions(-)


Its a huge change (with many details to look at), for a yet to be
understood need.

What sensible workload needs this at all ?

  parent reply	other threads:[~2012-05-30  7:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  7:36 [RFC PATCH 0/4] inet: add second hash table Alexandru Copot
2012-05-30  7:36 ` [RFC PATCH 1/4] inet: add counter to inet_bind_hashbucket Alexandru Copot
2012-05-30  8:00   ` Eric Dumazet
2012-05-30  7:36 ` [RFC PATCH 2/4] inet: add a second bind hash Alexandru Copot
2012-05-30  7:36 ` [RFC PATCH 3/4] inet: add/remove inet buckets in the " Alexandru Copot
2012-05-30  7:36 ` [RFC PATCH 4/4] inet: use second hash in inet_csk_get_port Alexandru Copot
2012-05-30 16:42   ` Eric Dumazet
2012-05-30 17:20   ` Eric Dumazet
2012-05-30 19:11     ` Alexandru Copot
2012-05-30  7:57 ` Eric Dumazet [this message]
2012-05-30 12:32   ` [RFC PATCH 0/4] inet: add second hash table Daniel Baluta
2012-05-30 12:41     ` Eric Dumazet
2012-05-30 16:27       ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338364640.2760.96.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=alex.mihai.c@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dbaluta@ixiacom.com \
    --cc=gerrit@erg.abdn.ac.uk \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=lucian.grijincu@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox