From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexandru Copot <alex.mihai.c@gmail.com>
Cc: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
netdev@vger.kernel.org, Daniel Baluta <dbaluta@ixiacom.com>,
Lucian Grijincu <lucian.grijincu@gmail.com>
Subject: Re: [RFC PATCH 4/4] inet: use second hash in inet_csk_get_port
Date: Wed, 30 May 2012 18:42:52 +0200 [thread overview]
Message-ID: <1338396172.2760.294.camel@edumazet-glaptop> (raw)
In-Reply-To: <1338363410-6562-5-git-send-email-alex.mihai.c@gmail.com>
On Wed, 2012-05-30 at 10:36 +0300, Alexandru Copot wrote:
> diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h
> index bc06168..2f589bb 100644
> --- a/include/net/inet_hashtables.h
> +++ b/include/net/inet_hashtables.h
> @@ -81,6 +81,15 @@ struct inet_bind_bucket {
> struct net *ib_net;
> #endif
> unsigned short port;
> + union {
> + struct in6_addr ib_addr_ipv6;
> + struct {
> + __be32 _1;
> + __be32 _2;
> + __be32 _3;
> + __be32 ib_addr_ipv4;
> + };
> + };
> signed short fastreuse;
> int num_owners;
> struct hlist_node node;
Yet another poor choice, adding two holes in this structure.
next prev parent reply other threads:[~2012-05-30 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 7:36 [RFC PATCH 0/4] inet: add second hash table Alexandru Copot
2012-05-30 7:36 ` [RFC PATCH 1/4] inet: add counter to inet_bind_hashbucket Alexandru Copot
2012-05-30 8:00 ` Eric Dumazet
2012-05-30 7:36 ` [RFC PATCH 2/4] inet: add a second bind hash Alexandru Copot
2012-05-30 7:36 ` [RFC PATCH 3/4] inet: add/remove inet buckets in the " Alexandru Copot
2012-05-30 7:36 ` [RFC PATCH 4/4] inet: use second hash in inet_csk_get_port Alexandru Copot
2012-05-30 16:42 ` Eric Dumazet [this message]
2012-05-30 17:20 ` Eric Dumazet
2012-05-30 19:11 ` Alexandru Copot
2012-05-30 7:57 ` [RFC PATCH 0/4] inet: add second hash table Eric Dumazet
2012-05-30 12:32 ` Daniel Baluta
2012-05-30 12:41 ` Eric Dumazet
2012-05-30 16:27 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338396172.2760.294.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alex.mihai.c@gmail.com \
--cc=davem@davemloft.net \
--cc=dbaluta@ixiacom.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=lucian.grijincu@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox