From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Steffen Klassert
<steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org>
Cc: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH net-next v2 1/2] inetpeer: add namespace support for inetpeer
Date: Tue, 05 Jun 2012 14:18:14 +0200 [thread overview]
Message-ID: <1338898694.2760.2478.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120605121510.GD27795-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org>
On Tue, 2012-06-05 at 14:15 +0200, Steffen Klassert wrote:
> Lookups are done under rcu, yes. But a lookup will not find
> these stale entries because the whole interpeer tree is removed
> from the inetpeer base before the worker is scheduled. A lookup
> would have to cerate a new inetpeer entry in this case.
>
Thats simply not true. You don't respect basic RCU rules.
Please read them.
next prev parent reply other threads:[~2012-06-05 12:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 7:52 [PATCH net-next v2 1/2] inetpeer: add namespace support for inetpeer Gao feng
[not found] ` <1338882737-11914-1-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-06-05 7:52 ` [PATCH net-next v2 2/2] inetpeer: add parameter net for inet_getpeer_v4, v6 Gao feng
2012-06-05 8:57 ` [PATCH net-next v2 1/2] inetpeer: add namespace support for inetpeer Eric Dumazet
2012-06-05 11:27 ` Steffen Klassert
2012-06-05 12:00 ` Eric Dumazet
2012-06-05 12:15 ` Steffen Klassert
[not found] ` <20120605121510.GD27795-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org>
2012-06-05 12:18 ` Eric Dumazet [this message]
2012-06-05 12:29 ` Gao feng
2012-06-06 17:43 ` David Miller
[not found] ` <20120606.104323.1698446129331745479.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-07 21:43 ` David Miller
[not found] ` <20120607.144301.1259354794384347085.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-08 1:44 ` Gao feng
2012-06-08 3:53 ` David Miller
[not found] ` <20120607.205348.913373847915721607.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-08 5:27 ` Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338898694.2760.2478.camel@edumazet-glaptop \
--to=eric.dumazet-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox