* [PATCH] NFC: Fix possible NULL ptr deref when getting the name of a socket
@ 2012-06-06 21:02 Sasha Levin
0 siblings, 0 replies; only message in thread
From: Sasha Levin @ 2012-06-06 21:02 UTC (permalink / raw)
To: lauro.venancio, aloisio.almeida, sameo, davem, linville
Cc: linux-wireless, netdev, linux-kernel, Sasha Levin
llcp_sock_getname() might get called before the LLCP socket was created.
This condition isn't checked, and llcp_sock_getname will simply deref a
NULL ptr in that case.
This exists starting with d646960 ("NFC: Initial LLCP support").
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
net/nfc/llcp/sock.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/nfc/llcp/sock.c b/net/nfc/llcp/sock.c
index 3f339b1..17a707d 100644
--- a/net/nfc/llcp/sock.c
+++ b/net/nfc/llcp/sock.c
@@ -292,6 +292,9 @@ static int llcp_sock_getname(struct socket *sock, struct sockaddr *addr,
pr_debug("%p\n", sk);
+ if (llcp_sock == NULL)
+ return -EBADFD;
+
addr->sa_family = AF_NFC;
*len = sizeof(struct sockaddr_nfc_llcp);
--
1.7.8.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-06-06 21:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-06 21:02 [PATCH] NFC: Fix possible NULL ptr deref when getting the name of a socket Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox