From: Eric Dumazet <eric.dumazet@gmail.com>
To: jeffrey.t.kirsher@intel.com
Cc: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"denys@visp.net.lb" <denys@visp.net.lb>,
"therbert@google.com" <therbert@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] e1000e: Change wthresh to 1 to avoid possible Tx stalls.
Date: Thu, 07 Jun 2012 06:24:45 +0200 [thread overview]
Message-ID: <1339043085.26966.77.camel@edumazet-glaptop> (raw)
In-Reply-To: <1339030752.2075.1.camel@jtkirshe-mobl>
On Wed, 2012-06-06 at 17:59 -0700, Jeff Kirsher wrote:
> After further internal review, NACK.
>
> This patch will cause unacceptable performance issues with non-ESB2
> parts.
>
> I am dropping this patch from my queue.
>
I'd like you share your performance numbers before NACKing this patch.
What is the alternative patch you guys have ?
next prev parent reply other threads:[~2012-06-07 4:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 8:43 [PATCH net] e1000e: Change wthresh to 1 to avoid possible Tx stalls Hiroaki SHIMODA
2012-06-06 8:46 ` Jeff Kirsher
2012-06-06 8:50 ` Eric Dumazet
2012-06-07 0:59 ` Jeff Kirsher
2012-06-07 1:34 ` David Miller
2012-06-07 4:24 ` Eric Dumazet [this message]
2012-06-07 4:52 ` Jeff Kirsher
2012-06-07 5:03 ` Eric Dumazet
2012-10-09 0:25 ` Frank Reppin
2012-10-09 6:07 ` Eric Dumazet
2012-10-09 17:36 ` Jesse Brandeburg
2012-10-09 21:02 ` Eric Dumazet
2012-10-09 22:48 ` Andre Tomt
2012-10-10 1:25 ` Frank Reppin
-- strict thread matches above, loose matches on Subject: below --
2012-10-11 1:34 [PATCH NET] " Jesse Brandeburg
2012-10-11 3:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339043085.26966.77.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=denys@visp.net.lb \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shimoda.hiroaki@gmail.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox