From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Early TCP socket demux.
Date: Tue, 19 Jun 2012 06:23:33 +0200 [thread overview]
Message-ID: <1340079813.7491.2164.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120618.211539.105938285016510975.davem@davemloft.net>
On Mon, 2012-06-18 at 21:15 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 19 Jun 2012 06:07:26 +0200
>
> > On Mon, 2012-06-18 at 19:40 -0700, David Miller wrote:
> >> You know you want it.
> >>
> >> Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> > Yeah, very good idea David ;)
> >
> > needs some polishing of course.
>
> Such as? IPv6 support?
>
I was referring to socket leak in :
+ if (sk) {
+ skb->sk = sk;
+ skb->destructor = sock_edemux;
+ if (sk->sk_state != TCP_TIME_WAIT) {
+ struct dst_entry *dst = sk->sk_rx_dst;
+ if (dst) {
+ skb_dst_set_noref(skb, dst);
+ err = 0;
+ }
+ }
+ }
next prev parent reply other threads:[~2012-06-19 4:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 2:40 [PATCH] ipv4: Early TCP socket demux David Miller
2012-06-19 4:03 ` Stephen Hemminger
2012-06-19 4:10 ` David Miller
2012-06-19 4:13 ` Changli Gao
2012-06-19 4:16 ` David Miller
2012-06-19 18:31 ` Stephen Hemminger
2012-06-19 4:07 ` Eric Dumazet
2012-06-19 4:15 ` David Miller
2012-06-19 4:23 ` Eric Dumazet [this message]
2012-06-19 4:25 ` Eric Dumazet
2012-06-19 4:27 ` David Miller
2012-06-19 4:37 ` Eric Dumazet
2012-06-19 6:07 ` David Miller
2012-06-19 6:28 ` Eric Dumazet
2012-06-19 4:26 ` David Miller
2012-06-19 4:31 ` Eric Dumazet
2012-06-19 4:43 ` Changli Gao
2012-06-19 4:47 ` Eric Dumazet
2012-06-19 4:51 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340079813.7491.2164.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox