Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, dbaryshkov@gmail.com
Subject: Re: [PATCH net-next 1/2] ieee802154: sparse warnings: make symbols static
Date: Mon, 02 Jul 2012 08:44:36 +0200	[thread overview]
Message-ID: <1341211476.5269.2.camel@edumazet-glaptop> (raw)
In-Reply-To: <1341211072.5269.0.camel@edumazet-glaptop>

On Mon, 2012-07-02 at 08:37 +0200, Eric Dumazet wrote:
> On Mon, 2012-07-02 at 10:18 +0400, Alexander Smirnov wrote:
> > Make symbols static to avoid the following warning shown up
> > by sparse:
> > 
> >     warning: symbol ... was not declared. Should it be static?
> > 
> > Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
> > ---
> >  net/ieee802154/6lowpan.c |    2 +-
> >  net/mac802154/mac_cmd.c  |    2 +-
> >  net/mac802154/mib.c      |    2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> > index cd5007f..17ad28f 100644
> > --- a/net/ieee802154/6lowpan.c
> > +++ b/net/ieee802154/6lowpan.c
> > @@ -124,7 +124,7 @@ struct lowpan_fragment {
> >  
> >  static unsigned short fragment_tag;
> >  static LIST_HEAD(lowpan_fragments);
> > -spinlock_t flist_lock;
> > +static spinlock_t flist_lock;
> >  
> 
> static DEFINE_SPINLOCK(flist_lock);


and of course commit 768f7c7c121e80f4 (6lowpan: add missing
spin_lock_init() ) must be reverted.

  reply	other threads:[~2012-07-02  6:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02  6:18 [PATCH net-next 0/0] fix sparse warnings Alexander Smirnov
2012-07-02  6:18 ` [PATCH net-next 1/2] ieee802154: sparse warnings: make symbols static Alexander Smirnov
2012-07-02  6:37   ` Eric Dumazet
2012-07-02  6:44     ` Eric Dumazet [this message]
2012-07-02  6:49       ` Eric Dumazet
2012-07-02  6:53         ` Alexander Smirnov
2012-07-02  7:09           ` Eric Dumazet
2012-07-02  7:13             ` Eric Dumazet
2012-07-04 13:38         ` Alexander Smirnov
2012-07-04 13:45           ` Eric Dumazet
2012-07-02  6:18 ` [PATCH net-next 2/2] drivers/ieee802154/at231rf230: remove unused return status Alexander Smirnov
2012-07-05 10:13   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341211476.5269.2.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=alex.bluesman.smirnov@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dbaryshkov@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox