From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, dbaryshkov@gmail.com
Subject: Re: [PATCH net-next 1/2] ieee802154: sparse warnings: make symbols static
Date: Mon, 02 Jul 2012 09:09:02 +0200 [thread overview]
Message-ID: <1341212942.5269.10.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAJmB2rDB6McXg=O_z-M3xFa0OrB5hkTWT=ZHM975GDTPvuGjtQ@mail.gmail.com>
On Mon, 2012-07-02 at 10:53 +0400, Alexander Smirnov wrote:
> Dear Eric,
>
> >> > static DEFINE_SPINLOCK(flist_lock);
> >>
> >>
> >> and of course commit 768f7c7c121e80f4 (6lowpan: add missing
> >> spin_lock_init() ) must be reverted.
> >
> > You should validate this code with LOCKDEP
> >
> > lowpan_dellink() does a spin_lock(&flist_lock);
> > while same lock can be taken by lowpan_fragment_timer_expired() from
> > timer irq, -> deadlock.
> >
> > del_timer() probably needs a del_timer_sync() too
> >
>
> Thanks a lot for the hints!
While you are changing this code, please add in
lowpan_alloc_new_frame() :
- use netdev_alloc_skb_ip_align() instead of alloc_skb() to get some
extra headroom in case we need to forward this frame in a tunnel or
something...
- initialize frame->lock
next prev parent reply other threads:[~2012-07-02 7:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 6:18 [PATCH net-next 0/0] fix sparse warnings Alexander Smirnov
2012-07-02 6:18 ` [PATCH net-next 1/2] ieee802154: sparse warnings: make symbols static Alexander Smirnov
2012-07-02 6:37 ` Eric Dumazet
2012-07-02 6:44 ` Eric Dumazet
2012-07-02 6:49 ` Eric Dumazet
2012-07-02 6:53 ` Alexander Smirnov
2012-07-02 7:09 ` Eric Dumazet [this message]
2012-07-02 7:13 ` Eric Dumazet
2012-07-04 13:38 ` Alexander Smirnov
2012-07-04 13:45 ` Eric Dumazet
2012-07-02 6:18 ` [PATCH net-next 2/2] drivers/ieee802154/at231rf230: remove unused return status Alexander Smirnov
2012-07-05 10:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341212942.5269.10.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox