From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/5] rtcache remove respin
Date: Mon, 02 Jul 2012 12:44:01 +0200 [thread overview]
Message-ID: <1341225841.5269.69.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120701.050243.908285695895815999.davem@davemloft.net>
On Sun, 2012-07-01 at 05:02 -0700, David Miller wrote:
> It's been a while and there were of course a lot of merge hassles with
> the most recent set I posted, so I respun these patches tonight
> because I wanted to see the effects of the recent rpfilter hacks on an
> rtcache-less system.
>
> On a SPARC T3-1:
>
> 1) Output route lookup: ~2800 cycles
> 2) Input route lookups: ~3000 cycles (rpfilter=0)
> ~4300 cycles (rpfilter=1)
>
> Another nice part is how small struct rtable is after this patch set:
>
> struct rtable {
> struct dst_entry dst;
> int rt_genid;
> unsigned int rt_flags;
> __u16 rt_type;
> __be32 rt_dst;
> int rt_route_iif;
> int rt_iif;
> int rt_oif;
> __be32 rt_gateway;
> u32 rt_peer_genid;
> unsigned long _peer;
> struct fib_info *fi;
> };
>
> which is about 208 bytes on sparc64.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Can be <= 192 actually
rcu_head not needed anymore in dst_entry
If we still want __refcnt being on cache line boundary, we might find a
better way to accomplish this.
next prev parent reply other threads:[~2012-07-02 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 12:02 [PATCH 0/5] rtcache remove respin David Miller
2012-07-01 12:15 ` David Miller
2012-07-03 10:56 ` David Miller
2012-07-02 10:44 ` Eric Dumazet [this message]
2012-07-02 10:59 ` David Miller
2012-07-05 10:15 ` David Miller
2012-07-05 19:03 ` Eric Dumazet
2012-07-05 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341225841.5269.69.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox