From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: TCP transmit performance regression
Date: Thu, 05 Jul 2012 12:41:59 +0200 [thread overview]
Message-ID: <1341484919.2583.3688.camel@edumazet-glaptop> (raw)
In-Reply-To: <CACVXFVNZ=64+=w1ZapXeXq7oYz0OBbBRLuH8rNSeDHyz7zGOZw@mail.gmail.com>
On Thu, 2012-07-05 at 18:32 +0800, Ming Lei wrote:
> After testing on beagle-xm, the patch is good and network is OK, but
> iperf performance is still no improvement, see below:
>
> [root@root]#iperf -c 192.168.0.103 -w 131072 -t 10
> ------------------------------------------------------------
> Client connecting to 192.168.0.103, TCP port 5001
> TCP window size: 256 KByte (WARNING: requested 128 KByte)
> ------------------------------------------------------------
> [ 3] local 192.168.0.119 port 46776 connected with 192.168.0.103 port 5001
> [ ID] Interval Transfer Bandwidth
> [ 3] 0.0-10.0 sec 41.4 MBytes 34.7 Mbits/sec
>
I fear there are copies in the tx path as well, in smsc95xx_tx_fixup()
Could you add traces in this function to check if skb_copy_expand() is
called ?
next prev parent reply other threads:[~2012-07-05 10:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 1:45 TCP transmit performance regression Ming Lei
2012-07-05 7:43 ` Eric Dumazet
2012-07-05 8:27 ` Ming Lei
2012-07-05 8:33 ` Eric Dumazet
2012-07-05 8:42 ` Ming Lei
2012-07-05 9:49 ` Eric Dumazet
2012-07-05 10:02 ` David Miller
2012-07-05 10:32 ` Ming Lei
2012-07-05 10:41 ` Eric Dumazet [this message]
2012-07-05 14:01 ` Ming Lei
2012-07-05 14:28 ` Eric Dumazet
2012-07-05 14:56 ` Eric Dumazet
2012-07-06 0:45 ` Ming Lei
2012-07-06 4:58 ` Eric Dumazet
2012-07-06 5:16 ` Eric Dumazet
2012-07-09 5:13 ` Ming Lei
2012-07-09 13:23 ` Ming Lei
2012-07-09 13:54 ` Eric Dumazet
[not found] ` <CACVXFVNdiwVn1Mo--N4N0HdYrEJizExtd_cppT4tS=mjog2PKw@mail.gmail.com>
[not found] ` <1341895143.3265.4049.camel@edumazet-glaptop>
2012-07-10 7:22 ` Ming Lei
2012-07-10 8:28 ` Eric Dumazet
2012-07-10 13:37 ` Ming Lei
2012-07-10 14:02 ` Eric Dumazet
2012-07-10 14:22 ` Ming Lei
2012-07-10 14:45 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341484919.2583.3688.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox