public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: TCP transmit performance regression
Date: Tue, 10 Jul 2012 16:02:11 +0200	[thread overview]
Message-ID: <1341928931.3265.5263.camel@edumazet-glaptop> (raw)
In-Reply-To: <CACVXFVM-fhQJX+EFNoFSnuVAjqfRM7OjzbQML7H+tMEjxG7Rug@mail.gmail.com>

I am kind of annoyed you sent on netdev a copy of a _private_ mail.

Next time, make sure you dont do that without my consent.

On Tue, 2012-07-10 at 21:37 +0800, Ming Lei wrote:

> Could you explain why the truesize of SKB is 8KB for single
> 1500bytes frame?
> 

Because the driver uses skb_alloc(4096) for example ?

I don't know, you don't tell us the driver.


Goal is to have skb->head points to a 2048 bytes area, so truesize
should be 2048 + sizeof(sk_buff)  (including struct shared_info)

> I observed it is 2560bytes for RX SKBs inside asix_rx_fixup with
> rx_urb_size of 2048 on beagle-xm.
> 

Thats because using 2048 bytes for the urb buffer (excluding
shared_info) means you need :

2048 + sizeof(struct shared_info) + sizeof(sk_buff) = 2560

In fact 2048 + sizeof(struct shared_info) means a full 4096 area is
used.

You have 2560 on recent kernels because the way netdev_alloc_frag()
works.

Thats why copybreak can actually saves ram. Since it is adding a copy,
we try to use it only on slow devices.

  reply	other threads:[~2012-07-10 14:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05  1:45 TCP transmit performance regression Ming Lei
2012-07-05  7:43 ` Eric Dumazet
2012-07-05  8:27   ` Ming Lei
2012-07-05  8:33     ` Eric Dumazet
2012-07-05  8:42       ` Ming Lei
2012-07-05  9:49         ` Eric Dumazet
2012-07-05 10:02           ` David Miller
2012-07-05 10:32           ` Ming Lei
2012-07-05 10:41             ` Eric Dumazet
2012-07-05 14:01               ` Ming Lei
2012-07-05 14:28                 ` Eric Dumazet
2012-07-05 14:56                 ` Eric Dumazet
2012-07-06  0:45                   ` Ming Lei
2012-07-06  4:58                     ` Eric Dumazet
2012-07-06  5:16                       ` Eric Dumazet
2012-07-09  5:13                         ` Ming Lei
2012-07-09 13:23           ` Ming Lei
2012-07-09 13:54             ` Eric Dumazet
     [not found]               ` <CACVXFVNdiwVn1Mo--N4N0HdYrEJizExtd_cppT4tS=mjog2PKw@mail.gmail.com>
     [not found]                 ` <1341895143.3265.4049.camel@edumazet-glaptop>
2012-07-10  7:22                   ` Ming Lei
2012-07-10  8:28                     ` Eric Dumazet
2012-07-10 13:37                       ` Ming Lei
2012-07-10 14:02                         ` Eric Dumazet [this message]
2012-07-10 14:22                           ` Ming Lei
2012-07-10 14:45                             ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341928931.3265.5263.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox