From: Joe Perches <joe@perches.com>
To: Valentin Ilie <valentin.ilie@gmail.com>
Cc: zbr@ioremap.net, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers: connector: fixed coding style issues
Date: Sat, 14 Jul 2012 13:33:46 -0700 [thread overview]
Message-ID: <1342298026.8377.33.camel@joe2Laptop> (raw)
In-Reply-To: <1342297608-6872-1-git-send-email-valentin.ilie@gmail.com>
On Sat, 2012-07-14 at 23:26 +0300, Valentin Ilie wrote:
> Fixed checkpatch warnings.
[]
> diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c
[]
> @@ -328,8 +328,8 @@ static int __init cn_proc_init(void)
> int err;
>
> if ((err = cn_add_callback(&cn_proc_event_id, "cn_proc",
> - &cn_proc_mcast_ctl))) {
> - printk(KERN_WARNING "cn_proc failed to register\n");
> + &cn_proc_mcast_ctl))) {
> + pr_warn("cn_proc failed to register\n");
I don't believe the first part of this change is a checkpatch
message. I think it would be better written by hoisting the
function outside the if like:
err = cn_add_callback(&cn_proc_event_id, "cn_proc", &cn_proc_mcast_ctl)
if (err) {
pr_warn("cn_proc failed to register\n");
return err;
}
next prev parent reply other threads:[~2012-07-14 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 20:26 [PATCH] drivers: connector: fixed coding style issues Valentin Ilie
2012-07-14 20:33 ` Joe Perches [this message]
2012-07-14 21:51 ` Valentin Ilie
2012-07-14 21:56 ` Joe Perches
2012-07-17 6:24 ` David Miller
2012-07-17 7:26 ` Evgeniy Polyakov
2012-07-14 23:08 ` [PATCH V2] " Valentin Ilie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342298026.8377.33.camel@joe2Laptop \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=valentin.ilie@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox