From: Joe Perches <joe@perches.com>
To: Valentin Ilie <valentin.ilie@gmail.com>
Cc: zbr@ioremap.net, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers: connector: fixed coding style issues
Date: Sat, 14 Jul 2012 14:56:20 -0700 [thread overview]
Message-ID: <1342302980.8377.43.camel@joe2Laptop> (raw)
In-Reply-To: <CAHuBVBYXAj7OUgo3UmLERbcmBw-sK8c66TuCq_7Fsp=CVzzYSw@mail.gmail.com>
On Sun, 2012-07-15 at 00:51 +0300, Valentin Ilie wrote:
> On 14 July 2012 23:33, Joe Perches <joe@perches.com> wrote:
> > I think it would be better written by hoisting the
> > function outside the if like [..]
>
> OK.
>
> Should I submit the whole patch again (with that change) or just
> another small patch that does just that?
It's generally better to reply to the original patch
with [PATCH V2] with the entire patch content updated.
btw: there's a missing a semicolon in what I posted.
Also add a changelog after the --- so the new patch
email looks like:
Subject: [PATCH V2] drivers: connectors: etc
Patch description...
Signed-off-by: etc
---
v2: Updated to do whatever
actual patch...
cheers, Joe
next prev parent reply other threads:[~2012-07-14 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 20:26 [PATCH] drivers: connector: fixed coding style issues Valentin Ilie
2012-07-14 20:33 ` Joe Perches
2012-07-14 21:51 ` Valentin Ilie
2012-07-14 21:56 ` Joe Perches [this message]
2012-07-17 6:24 ` David Miller
2012-07-17 7:26 ` Evgeniy Polyakov
2012-07-14 23:08 ` [PATCH V2] " Valentin Ilie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342302980.8377.43.camel@joe2Laptop \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=valentin.ilie@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox