From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, therbert@google.com, wsommerfeld@google.com
Subject: Re: [PATCH net-next] ipv4: tcp: remove per net tcp_sock
Date: Thu, 19 Jul 2012 19:08:34 +0200 [thread overview]
Message-ID: <1342717714.2626.4495.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120719.083544.1223522161508413373.davem@davemloft.net>
On Thu, 2012-07-19 at 08:35 -0700, David Miller wrote:
> > @@ -2624,13 +2624,11 @@ EXPORT_SYMBOL(tcp_prot);
> >
> > static int __net_init tcp_sk_init(struct net *net)
> > {
> > - return inet_ctl_sock_create(&net->ipv4.tcp_sock,
> > - PF_INET, SOCK_RAW, IPPROTO_TCP, net);
> > + return 0;
> > }
> >
> > static void __net_exit tcp_sk_exit(struct net *net)
> > {
> > - inet_ctl_sock_destroy(net->ipv4.tcp_sock);
> > }
> >
> > static void __net_exit tcp_sk_exit_batch(struct list_head *net_exit_list)
>
> If these no longer really do anything, just send me a patch to kill
> them off entirely.
>
We cant remove them, because of tcp_sk_exit_batch()
prev parent reply other threads:[~2012-07-19 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 8:58 [PATCH net-next] ipv4: tcp: remove per net tcp_sock Eric Dumazet
2012-07-19 15:35 ` David Miller
2012-07-19 15:45 ` David Miller
2012-07-19 17:07 ` Eric Dumazet
2012-07-19 17:11 ` David Miller
2012-07-19 17:12 ` David Miller
2012-07-19 17:22 ` Eric Dumazet
2012-07-19 17:08 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342717714.2626.4495.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=wsommerfeld@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox