From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, therbert@google.com, wsommerfeld@google.com
Subject: Re: [PATCH net-next] ipv4: tcp: remove per net tcp_sock
Date: Thu, 19 Jul 2012 10:11:55 -0700 (PDT) [thread overview]
Message-ID: <20120719.101155.1970854797296520147.davem@davemloft.net> (raw)
In-Reply-To: <1342717667.2626.4494.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 19 Jul 2012 19:07:47 +0200
> On Thu, 2012-07-19 at 08:45 -0700, David Miller wrote:
>> From: David Miller <davem@davemloft.net>
>> Date: Thu, 19 Jul 2012 08:35:44 -0700 (PDT)
>>
>> > Looks great, applied, thanks Eric.
>>
>> I take that back, it doesn't build:
>>
>> net/ipv4/ip_output.c: In function ‘ip_send_unicast_reply’:
>> net/ipv4/ip_output.c:1481:1: error: section attribute cannot be specified for local variables
>> net/ipv4/ip_output.c:1481:1: error: section attribute cannot be specified for local variables
>> net/ipv4/ip_output.c:1481:1: error: declaration of ‘__pcpu_unique_unicast_sock’ with no linkage follows extern declaration
>> net/ipv4/ip_output.c:1481:1: note: previous declaration of ‘__pcpu_unique_unicast_sock’ was here
>> net/ipv4/ip_output.c:1481:9: error: section attribute cannot be specified for local variables
>> net/ipv4/ip_output.c:1481:9: error: weak declaration of ‘unicast_sock’ must be public
>
> Strange, it builds on my machines, and I got nice performance boost.
>
> Apparently your arch doesnt handle the
>
> static DEFINE_PER_CPU(struct inet_sock, unicast_sock)
>
> in the function body ?
It's x86-64, standard Fedora 17 install.
next prev parent reply other threads:[~2012-07-19 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 8:58 [PATCH net-next] ipv4: tcp: remove per net tcp_sock Eric Dumazet
2012-07-19 15:35 ` David Miller
2012-07-19 15:45 ` David Miller
2012-07-19 17:07 ` Eric Dumazet
2012-07-19 17:11 ` David Miller [this message]
2012-07-19 17:12 ` David Miller
2012-07-19 17:22 ` Eric Dumazet
2012-07-19 17:08 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719.101155.1970854797296520147.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=wsommerfeld@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox