public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "David Miller" <davem@davemloft.net>,
	hayeswang@realtek.com, netdev@vger.kernel.org,
	"Alex Villacís Lasso" <a_villacis@palosanto.com>,
	"Josh Boyer" <jwboyer@redhat.com>,
	"Tom Herbert" <therbert@google.com>
Subject: Re: [PATCH] r8169: revert "add byte queue limit support".
Date: Tue, 24 Jul 2012 07:06:47 +0200	[thread overview]
Message-ID: <1343106407.2626.11038.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120723205555.GA4392@electric-eye.fr.zoreil.com>

On Mon, 2012-07-23 at 22:55 +0200, Francois Romieu wrote:
> This reverts commit 036dafa28da1e2565a8529de2ae663c37b7a0060.
> 
> First it appears in bisection, then reverting it solves the usual
> netdev watchdog problem for different people. I don't have a proper
> fix yet so get rid of it.
> 
> Bisected-and-reported-by: Alex Villacís Lasso <a_villacis@palosanto.com>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> Cc: Josh Boyer <jwboyer@redhat.com>
> Cc: Hayes Wang <hayeswang@realtek.com>
> ---

bisection is not always the right way to qualify a problem.

BQL in itself had some fixes coming _after_ commit 036dafa28da1e2565

Is there an easy way to reproduce the problem ?

Thanks

  parent reply	other threads:[~2012-07-24  5:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23 20:55 [PATCH] r8169: revert "add byte queue limit support" Francois Romieu
2012-07-24  1:27 ` David Miller
2012-07-24  5:06 ` Eric Dumazet [this message]
2012-07-24  5:09   ` Eric Dumazet
2012-07-24  5:38   ` Francois Romieu
2012-07-24 11:11     ` Josh Boyer
2012-07-27  3:36     ` Stefan Lippers-Hollmann
2012-07-27  5:27       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343106407.2626.11038.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=a_villacis@palosanto.com \
    --cc=davem@davemloft.net \
    --cc=hayeswang@realtek.com \
    --cc=jwboyer@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox