From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stefan Lippers-Hollmann <s.L-H@gmx.de>
Cc: "Francois Romieu" <romieu@fr.zoreil.com>,
"David Miller" <davem@davemloft.net>,
hayeswang@realtek.com, netdev@vger.kernel.org,
"Alex Villacís Lasso" <a_villacis@palosanto.com>,
"Josh Boyer" <jwboyer@redhat.com>,
"Tom Herbert" <therbert@google.com>
Subject: Re: [PATCH] r8169: revert "add byte queue limit support".
Date: Fri, 27 Jul 2012 07:27:48 +0200 [thread overview]
Message-ID: <1343366868.2626.12188.camel@edumazet-glaptop> (raw)
In-Reply-To: <201207270536.50292.s.L-H@gmx.de>
On Fri, 2012-07-27 at 05:36 +0200, Stefan Lippers-Hollmann wrote:
> Hi
>
> On Tuesday 24 July 2012, Francois Romieu wrote:
> > Eric Dumazet <eric.dumazet@gmail.com> :
> > > On Mon, 2012-07-23 at 22:55 +0200, Francois Romieu wrote:
> > > > This reverts commit 036dafa28da1e2565a8529de2ae663c37b7a0060.
> > [...]
> > > bisection is not always the right way to qualify a problem.
> >
> > I know. At some point I switch from "I could search more" to "users situation
> > will improve in a definite timeframe".
> >
> > > BQL in itself had some fixes coming _after_ commit 036dafa28da1e2565
> >
> > Thanks.
> >
> > They are in stable as of 3.4.5:
> […]
> > I have obviously not directed users at them and I do not see any
> > of the victims using a non -stable / -vendor or recent enough
> > kernel to test this patch since the issue has been reported.
> >
> > They are both worth testing.
> […]
>
> 3.4.x up to and including 3.4.4 exposed the problem on these cards[1]:
>
> r8169 0000:04:00.0: eth0: RTL8168d/8111d at 0xffffc90000c72000, 00:24:1d:72:7c:75, XID 081000c0 IRQ 44
> r8169 0000:05:00.0: eth1: RTL8168d/8111d at 0xffffc90000c70000, 00:24:1d:72:7c:77, XID 081000c0 IRQ 45
>
> while it is stable with "add byte queue limit support" reverted; 3.4.5+
> was only tested with 036dafa28da1e2565a8529de2ae663c37b7a0060 reverted.
>
> Now testing plain 3.5.0, which still includes it, has been reliable for
> almost 3 days - while the issue usually triggered within one hour (3
> hours at most) in 3.4.[0-4]. It might be a little too early to give a
> definitive answer, but so far r8169/ 3.5.0 looks positive.
>
> Regards
> Stefan Lippers-Hollmann
>
> [1] Message-Id: <201206290131.49150.s.L-H@gmx.de>
> http://lkml.kernel.org/r/<201206290131.49150.s.L-H@gmx.de>
Thats real good news, thanks !
prev parent reply other threads:[~2012-07-27 5:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 20:55 [PATCH] r8169: revert "add byte queue limit support" Francois Romieu
2012-07-24 1:27 ` David Miller
2012-07-24 5:06 ` Eric Dumazet
2012-07-24 5:09 ` Eric Dumazet
2012-07-24 5:38 ` Francois Romieu
2012-07-24 11:11 ` Josh Boyer
2012-07-27 3:36 ` Stefan Lippers-Hollmann
2012-07-27 5:27 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343366868.2626.12188.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=a_villacis@palosanto.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=jwboyer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=s.L-H@gmx.de \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox