From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <ogerlitz@mellanox.com>, <netdev@vger.kernel.org>,
<oren@mellanox.com>, <amirv@mellanox.com>
Subject: Re: [PATCH RESEND net] net/mlx4_en: Limit the RFS filter IDs to be < RPS_NO_FILTER
Date: Wed, 25 Jul 2012 23:29:54 +0100 [thread overview]
Message-ID: <1343255394.5132.145.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20120725.152337.155627167530086828.davem@davemloft.net>
On Wed, 2012-07-25 at 15:23 -0700, David Miller wrote:
> From: Or Gerlitz <ogerlitz@mellanox.com>
> Date: Wed, 25 Jul 2012 18:04:35 +0300
>
> > On 25/07/2012 17:57, Ben Hutchings wrote:
> >>> @@ -77,12 +77,8 @@ int mlx4_en_activate_cq(struct mlx4_en_priv *priv,
> >>> struct mlx4_en_cq *cq,
> >>> struct mlx4_en_dev *mdev = priv->mdev;
> >>> int err = 0;
> >>> char name[25];
> >>> - struct cpu_rmap *rmap =
> >>> -#ifdef CONFIG_RFS_ACCEL
> >>> - priv->dev->rx_cpu_rmap;
> >>> -#else
> >>> - NULL;
> >>> -#endif
> >>> + struct cpu_rmap *rmap = IS_ENABLED(CONFIG_RFS_ACCEL) ?
> >>> + priv->dev->rx_cpu_rmap : NULL;
> >>
> >> This is a separate change.
> >
> > OK, will send two patches
>
> This change breaks the build.
>
> You can't do this check at run-time, because the reason you need to
> check CONFIG_RFS_ACCEL is because if that's disabled then the netdev
> structure doesn't even have the ->rx_cpu_rmap member.
Yes, sorry for suggesting that, Or.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-07-25 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 14:36 [PATCH RESEND net] net/mlx4_en: Limit the RFS filter IDs to be < RPS_NO_FILTER Or Gerlitz
2012-07-25 14:57 ` Ben Hutchings
2012-07-25 15:04 ` Or Gerlitz
2012-07-25 22:23 ` David Miller
2012-07-25 22:29 ` Ben Hutchings [this message]
2012-07-25 14:57 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343255394.5132.145.camel@deadeye.wl.decadent.org.uk \
--to=bhutchings@solarflare.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=oren@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox