* [PATCH] libceph: Fix sparse warning
@ 2012-08-14 13:27 Iulius Curt
2012-08-22 9:46 ` Daniel Baluta
0 siblings, 1 reply; 3+ messages in thread
From: Iulius Curt @ 2012-08-14 13:27 UTC (permalink / raw)
To: davem; +Cc: sage, ceph-devel, netdev, dbaluta, Iulius Curt, Iulius Curt
From: Iulius Curt <iulius.curt@gmail.com>
Make ceph_monc_do_poolop() static to remove the following sparse warning:
* net/ceph/mon_client.c:616:5: warning: symbol 'ceph_monc_do_poolop' was not
declared. Should it be static?
Signed-off-by: Iulius Curt <icurt@ixiacom.com>
---
net/ceph/mon_client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c
index 105d533..3875c60 100644
--- a/net/ceph/mon_client.c
+++ b/net/ceph/mon_client.c
@@ -613,7 +613,7 @@ bad:
/*
* Do a synchronous pool op.
*/
-int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
+static int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
u32 pool, u64 snapid,
char *buf, int len)
{
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] libceph: Fix sparse warning
2012-08-14 13:27 [PATCH] libceph: Fix sparse warning Iulius Curt
@ 2012-08-22 9:46 ` Daniel Baluta
2012-08-22 15:53 ` Sage Weil
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Baluta @ 2012-08-22 9:46 UTC (permalink / raw)
To: sage; +Cc: davem, ceph-devel, netdev, Iulius Curt
On Tue, Aug 14, 2012 at 4:27 PM, Iulius Curt <iulius.curt@gmail.com> wrote:
> From: Iulius Curt <iulius.curt@gmail.com>
>
> Make ceph_monc_do_poolop() static to remove the following sparse warning:
> * net/ceph/mon_client.c:616:5: warning: symbol 'ceph_monc_do_poolop' was not
> declared. Should it be static?
>
> Signed-off-by: Iulius Curt <icurt@ixiacom.com>
> ---
> net/ceph/mon_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c
> index 105d533..3875c60 100644
> --- a/net/ceph/mon_client.c
> +++ b/net/ceph/mon_client.c
> @@ -613,7 +613,7 @@ bad:
> /*
> * Do a synchronous pool op.
> */
> -int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
> +static int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
> u32 pool, u64 snapid,
> char *buf, int len)
> {
> --
> 1.7.9.5
>
> --
Hi Sage,
Can you have a look on this? :)
thanks,
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] libceph: Fix sparse warning
2012-08-22 9:46 ` Daniel Baluta
@ 2012-08-22 15:53 ` Sage Weil
0 siblings, 0 replies; 3+ messages in thread
From: Sage Weil @ 2012-08-22 15:53 UTC (permalink / raw)
To: Daniel Baluta; +Cc: davem, ceph-devel, netdev, Iulius Curt
On Wed, 22 Aug 2012, Daniel Baluta wrote:
> On Tue, Aug 14, 2012 at 4:27 PM, Iulius Curt <iulius.curt@gmail.com> wrote:
> > From: Iulius Curt <iulius.curt@gmail.com>
> >
> > Make ceph_monc_do_poolop() static to remove the following sparse warning:
> > * net/ceph/mon_client.c:616:5: warning: symbol 'ceph_monc_do_poolop' was not
> > declared. Should it be static?
> >
> > Signed-off-by: Iulius Curt <icurt@ixiacom.com>
> > ---
> > net/ceph/mon_client.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c
> > index 105d533..3875c60 100644
> > --- a/net/ceph/mon_client.c
> > +++ b/net/ceph/mon_client.c
> > @@ -613,7 +613,7 @@ bad:
> > /*
> > * Do a synchronous pool op.
> > */
> > -int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
> > +static int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
> > u32 pool, u64 snapid,
> > char *buf, int len)
> > {
> > --
> > 1.7.9.5
> >
> > --
>
> Hi Sage,
>
> Can you have a look on this? :)
Sorry, this one fell through the cracks. Yes, we can switch it to static,
but while we're doing that let's drop the ceph_monc_ prefix too (since
it's private).
Thanks!
sage
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-22 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-14 13:27 [PATCH] libceph: Fix sparse warning Iulius Curt
2012-08-22 9:46 ` Daniel Baluta
2012-08-22 15:53 ` Sage Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox