From: Eric Dumazet <eric.dumazet@gmail.com>
To: Kevin Wilson <wkevils@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: copy_skb_header() and sk_buff flags (question)
Date: Wed, 22 Aug 2012 07:21:19 +0200 [thread overview]
Message-ID: <1345612879.5158.569.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAGXs5wVp2bLnwFiuYEg6ZOv0t3DX4PCCgY-EURbs5bySgEqtdw@mail.gmail.com>
On Wed, 2012-08-22 at 07:55 +0300, Kevin Wilson wrote:
> Hello,
>
> I have a question if I may, as I cannot understand this point:
>
> I try to understand why in __copy_skb_header() we copy various flags
> (like ip_summed,
> local_df, pkt_type, priority, ipvs_property, and more. But there are
> flags which we do
> not copy, like nohdr, or fclone, or peeked.
>
> Aren't these flags part of the sk_buff header?
Caller should take care of said bits.
peeked is probably always 0 at this point...
I tried to use a single memcpy() to speedup things, but found out
it was not a trivial thing...
prev parent reply other threads:[~2012-08-22 5:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 4:55 copy_skb_header() and sk_buff flags (question) Kevin Wilson
2012-08-22 5:21 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345612879.5158.569.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wkevils@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox