Netdev List
 help / color / mirror / Atom feed
* copy_skb_header() and sk_buff flags (question)
@ 2012-08-22  4:55 Kevin Wilson
  2012-08-22  5:21 ` Eric Dumazet
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wilson @ 2012-08-22  4:55 UTC (permalink / raw)
  To: netdev

Hello,

I have a question if I may, as I cannot understand this point:

I try to understand why in __copy_skb_header() we copy various flags
(like ip_summed,
local_df, pkt_type, priority, ipvs_property, and more. But there are
flags which we do
not copy, like nohdr, or fclone, or peeked.

 Aren't these flags part of the sk_buff header?

regards,
Kevin

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: copy_skb_header() and sk_buff flags (question)
  2012-08-22  4:55 copy_skb_header() and sk_buff flags (question) Kevin Wilson
@ 2012-08-22  5:21 ` Eric Dumazet
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2012-08-22  5:21 UTC (permalink / raw)
  To: Kevin Wilson; +Cc: netdev

On Wed, 2012-08-22 at 07:55 +0300, Kevin Wilson wrote:
> Hello,
> 
> I have a question if I may, as I cannot understand this point:
> 
> I try to understand why in __copy_skb_header() we copy various flags
> (like ip_summed,
> local_df, pkt_type, priority, ipvs_property, and more. But there are
> flags which we do
> not copy, like nohdr, or fclone, or peeked.
> 
>  Aren't these flags part of the sk_buff header?

Caller should take care of said bits.

peeked is probably always 0 at this point...

I tried to use a single memcpy() to speedup things, but found out
it was not a trivial thing...

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-22  5:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22  4:55 copy_skb_header() and sk_buff flags (question) Kevin Wilson
2012-08-22  5:21 ` Eric Dumazet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox