[PATCH] net_tx_action: Call trace_consume_skb() instead of trace_kfree_skb()

[Shawn Bohrer <sbohrer@rgmadvisors.com>]

Call trace_consume_skb() instead of trace_kfree_skb() as skbs are
removed from the completion_queue during transmit.  This avoids false
positives from dropwatch/drop_monitor making them more useful.

Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
---

In my case I seem to hit this tracepoint for every packet I transmit so
these appear to be false positives to me.  Perhaps there are cases where
you could hit this and it is a real packet drop?

 net/core/dev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 8398836..00774ce 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3015,7 +3015,7 @@ static void net_tx_action(struct softirq_action *h)
 			clist = clist->next;
 
 			WARN_ON(atomic_read(&skb->users));
-			trace_kfree_skb(skb, net_tx_action);
+			trace_consume_skb(skb);
 			__kfree_skb(skb);
 		}
 	}
-- 
1.7.7.6


-- 

---------------------------------------------------------------
This email, along with any attachments, is confidential. If you 
believe you received this message in error, please contact the 
sender immediately and delete all copies of the message.  
Thank you.