From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shawn Bohrer <sbohrer@rgmadvisors.com>
Cc: netdev@vger.kernel.org, sanagi.koki@jp.fujitsu.com, davem@davemloft.net
Subject: Re: [PATCH] net_tx_action: Call trace_consume_skb() instead of trace_kfree_skb()
Date: Wed, 12 Sep 2012 15:39:49 +0200 [thread overview]
Message-ID: <1347457189.13103.990.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120912132055.GA2884@BohrerMBP.rgmadvisors.com>
On Wed, 2012-09-12 at 08:20 -0500, Shawn Bohrer wrote:
> But I guess your question is who puts the skb on the completion_queue.
> In my case it looks like:
>
> dev_kfree_skb_irq()
> dev_kfree_skb_any()
> mlx4_en_free_tx_desc()
> mlx4_en_process_tx_cq()
> mlx4_en_xmit()
> dev_hard_start_xmit()
> # from here up the stack there seems to be several paths one of which is
> dev_queue_xmit()
> ip_finish_output()
> Does this answer your question about how I'm hitting this tracepoint?
Yes : this driver can do TX completion from its start_xmit() as well...
We need to add new helpers for dev_kfree_skb_any() and
dev_kfree_skb_irq(), but its quite a lot of work.
An alternative would be to set a bit in skb (skb->consumed)
prev parent reply other threads:[~2012-09-12 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 23:28 [PATCH] net_tx_action: Call trace_consume_skb() instead of trace_kfree_skb() Shawn Bohrer
2012-09-12 7:33 ` Eric Dumazet
2012-09-12 13:20 ` Shawn Bohrer
2012-09-12 13:39 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347457189.13103.990.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sanagi.koki@jp.fujitsu.com \
--cc=sbohrer@rgmadvisors.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox