From: Cyril Chemparathy <cyril@ti.com>
To: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <david.ward@ll.mit.edu>,
<eric.dumazet@gmail.com>, <jdowdal@ti.com>,
<paul.gortmaker@windriver.com>, Cyril Chemparathy <cyril@ti.com>
Subject: [PATCH] sch_red: fix weighted average calculation
Date: Thu, 13 Sep 2012 09:43:40 -0400 [thread overview]
Message-ID: <1347543820-27548-1-git-send-email-cyril@ti.com> (raw)
This patch fixes an apparent bug in the running weighted average calculation
used in the RED algorithm.
Going by the described formula:
qavg = qavg*(1-W) + backlog*W
=> qavg = qavg + (backlog - qavg) * W
... with W converted to a pre-calculated shift, this then becomes:
qavg = qavg + (backlog - qavg) >> logW
... giving the modified expression introduced by this patch.
Signed-off-by: John Dowdal <jdowdal@ti.com>
---
include/net/red.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/red.h b/include/net/red.h
index ef46058..05960a4 100644
--- a/include/net/red.h
+++ b/include/net/red.h
@@ -287,7 +287,7 @@ static inline unsigned long red_calc_qavg_no_idle_time(const struct red_parms *p
*
* --ANK (980924)
*/
- return v->qavg + (backlog - (v->qavg >> p->Wlog));
+ return v->qavg + (backlog - v->qavg) >> p->Wlog;
}
static inline unsigned long red_calc_qavg(const struct red_parms *p,
--
1.7.9.5
next reply other threads:[~2012-09-13 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 13:43 Cyril Chemparathy [this message]
2012-09-13 13:53 ` [PATCH] sch_red: fix weighted average calculation Eric Dumazet
2012-09-14 13:01 ` Dowdal, John
2012-09-14 13:13 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347543820-27548-1-git-send-email-cyril@ti.com \
--to=cyril@ti.com \
--cc=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=eric.dumazet@gmail.com \
--cc=jdowdal@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox