From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Dowdal, John" <jdowdal@ti.com>
Cc: "Chemparathy, Cyril" <cyril@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"david.ward@ll.mit.edu" <david.ward@ll.mit.edu>,
"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>
Subject: RE: [PATCH] sch_red: fix weighted average calculation
Date: Fri, 14 Sep 2012 15:13:16 +0200 [thread overview]
Message-ID: <1347628396.26523.6.camel@edumazet-glaptop> (raw)
In-Reply-To: <2D29FFBF554947468515B8EF6C733BB72E564F65@DLEE09.ent.ti.com>
On Fri, 2012-09-14 at 13:01 +0000, Dowdal, John wrote:
> Eric, thank you for reviewing the code. I now see the problem with
> the patch since backlog is an integer and qavg is a fixed point number
> at logW.
>
> We are considering another patch to update the comments to this code
> (with the actual C code change reverted) to stop the FPP by showing
> the derivation of the equation in the comments. Does this sound good?
This would be good, please do so.
Thanks
prev parent reply other threads:[~2012-09-14 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 13:43 [PATCH] sch_red: fix weighted average calculation Cyril Chemparathy
2012-09-13 13:53 ` Eric Dumazet
2012-09-14 13:01 ` Dowdal, John
2012-09-14 13:13 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347628396.26523.6.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=cyril@ti.com \
--cc=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=jdowdal@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox