From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>, Ying Cai <ycai@google.com>
Subject: [PATCH net-next] mlx4: use dev_kfree_skb() instead of dev_kfree_skb_any()
Date: Mon, 17 Sep 2012 09:29:34 +0200 [thread overview]
Message-ID: <1347866974.26523.53.camel@edumazet-glaptop> (raw)
From: Eric Dumazet <edumazet@google.com>
Since commit e22979d96a5 (mlx4_en: Moving to Interrupts for TX
completions), we no longer can free TX skb from hard IRQ, but only from
normal softirq or process context.
Therefore, we can directly call dev_kfree_skb() from
mlx4_en_free_tx_desc() like other conventional NAPI drivers.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Ying Cai <ycai@google.com>
---
drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index 10bba09..e182762 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -266,7 +266,7 @@ static u32 mlx4_en_free_tx_desc(struct mlx4_en_priv *priv,
}
}
- dev_kfree_skb_any(skb);
+ dev_kfree_skb(skb);
return tx_info->nr_txbb;
}
next reply other threads:[~2012-09-17 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 7:29 Eric Dumazet [this message]
2012-09-18 19:58 ` [PATCH net-next] mlx4: use dev_kfree_skb() instead of dev_kfree_skb_any() Or Gerlitz
2012-09-19 7:58 ` Yevgeny Petrilin
2012-09-19 12:12 ` Eric Dumazet
2012-09-19 21:21 ` Ying Cai
2012-09-20 7:03 ` Yevgeny Petrilin
2012-09-28 17:53 ` [PATCH net-next] mlx4: dont orphan skbs in mlx4_en_xmit() Eric Dumazet
2012-09-30 6:49 ` Yevgeny Petrilin
2012-10-01 21:02 ` David Miller
2012-10-01 21:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347866974.26523.53.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ycai@google.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox