From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yevgeny Petrilin <yevgenyp@mellanox.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>, Ying Cai <ycai@google.com>
Subject: RE: [PATCH net-next] mlx4: use dev_kfree_skb() instead of dev_kfree_skb_any()
Date: Wed, 19 Sep 2012 14:12:57 +0200 [thread overview]
Message-ID: <1348056777.26523.750.camel@edumazet-glaptop> (raw)
In-Reply-To: <953B660C027164448AE903364AC447D28721B46E@MTLDAG01.mtl.com>
On Wed, 2012-09-19 at 07:58 +0000, Yevgeny Petrilin wrote:
> >
> > Since commit e22979d96a5 (mlx4_en: Moving to Interrupts for TX
> > completions), we no longer can free TX skb from hard IRQ, but only from
> > normal softirq or process context.
> >
> > Therefore, we can directly call dev_kfree_skb() from
> > mlx4_en_free_tx_desc() like other conventional NAPI drivers.
> >
>
> Hi Eric,
> At the moment the TX completion processing is done from IRQ context.
> So I think we need to change the driver to work with NAPI for TX completions
> before making this change.
>
> I'll send the patch in a few days.
Oops you're right, it seems I misread e22979d96 commit.
irq term is a bit generic, you might add soft/hard qualifiers to
distinguish the variant.
Thanks
next prev parent reply other threads:[~2012-09-19 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 7:29 [PATCH net-next] mlx4: use dev_kfree_skb() instead of dev_kfree_skb_any() Eric Dumazet
2012-09-18 19:58 ` Or Gerlitz
2012-09-19 7:58 ` Yevgeny Petrilin
2012-09-19 12:12 ` Eric Dumazet [this message]
2012-09-19 21:21 ` Ying Cai
2012-09-20 7:03 ` Yevgeny Petrilin
2012-09-28 17:53 ` [PATCH net-next] mlx4: dont orphan skbs in mlx4_en_xmit() Eric Dumazet
2012-09-30 6:49 ` Yevgeny Petrilin
2012-10-01 21:02 ` David Miller
2012-10-01 21:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348056777.26523.750.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ycai@google.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).