public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] netfilter: xt_TEE: dont use destination address found in header
       [not found]       ` <20121017081551.GA12998@1984>
@ 2012-10-17  8:33         ` Eric Dumazet
  0 siblings, 0 replies; only message in thread
From: Eric Dumazet @ 2012-10-17  8:33 UTC (permalink / raw)
  To: Pablo Neira Ayuso
  Cc: Torsten Luettgert, netfilter-devel, netdev, Julian Anastasov

From-off-by: Eric Dumazet <edumazet@google.com>

Torsten Luettgert bisected TEE regression starting with commit
f8126f1d5136be1 (ipv4: Adjust semantics of rt->rt_gateway.)

The problem is that it tries to ARP-lookup the original destination
address of the forwarded packet, not the address of the gateway.

Fix this using FLOWI_FLAG_KNOWN_NH Julian added in commit
c92b96553a80c1 (ipv4: Add FLOWI_FLAG_KNOWN_NH), so that known
nexthop (info->gw.ip) has preference on resolving.

Reported-by: Torsten Luettgert <ml-netfilter@enda.eu>
Bisected-by: Torsten Luettgert <ml-netfilter@enda.eu>
Tested-by: Torsten Luettgert <ml-netfilter@enda.eu>
Cc: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/netfilter/xt_TEE.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netfilter/xt_TEE.c b/net/netfilter/xt_TEE.c
index ee2e5bc..bd93e51 100644
--- a/net/netfilter/xt_TEE.c
+++ b/net/netfilter/xt_TEE.c
@@ -70,6 +70,7 @@ tee_tg_route4(struct sk_buff *skb, const struct xt_tee_tginfo *info)
 	fl4.daddr = info->gw.ip;
 	fl4.flowi4_tos = RT_TOS(iph->tos);
 	fl4.flowi4_scope = RT_SCOPE_UNIVERSE;
+	fl4.flowi4_flags = FLOWI_FLAG_KNOWN_NH;
 	rt = ip_route_output_key(net, &fl4);
 	if (IS_ERR(rt))
 		return false;



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-10-17  8:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20121016211319.3f07a7e3@goldlack.enda.eu>
     [not found] ` <1350417618.3954.1494.camel@edumazet-glaptop>
     [not found]   ` <20121017094543.2ddb0397@goldlack.enda.eu>
     [not found]     ` <1350460131.26103.68.camel@edumazet-glaptop>
     [not found]       ` <20121017081551.GA12998@1984>
2012-10-17  8:33         ` [PATCH] netfilter: xt_TEE: dont use destination address found in header Eric Dumazet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox