From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: netdev@vger.kernel.org
Subject: Re: sock_getsockopt() not exported
Date: Thu, 18 Oct 2012 11:30:12 +0200 [thread overview]
Message-ID: <1350552612.26103.1281.camel@edumazet-glaptop> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7052@saturn3.aculab.com>
On Thu, 2012-10-18 at 10:11 +0100, David Laight wrote:
> I've noticed that net/core/sock.c contains an
> EXPORT_SYMBOL(sock_setsockopt)
> but is missing the corresponding
> EXPORT_SYMBOL(sock_getsockopt)
>
> In-kernel users of sockets probably manage without
> needing to read SOL_SOCKET options.
> (They do need to set SO_REUSADDR and SO_KEEPALIVE.)
sock_setsockopt() is exported because sunrpc needs it, and sunrpc can be
a module
sock_getsockopt() is not exported because no module needs it yet.
The day one user needs it, we'll add the EXPORT_SYMBOL()
next prev parent reply other threads:[~2012-10-18 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 9:11 sock_getsockopt() not exported David Laight
2012-10-18 9:30 ` Eric Dumazet [this message]
2012-10-18 12:03 ` David Laight
2012-10-18 12:27 ` Eric Dumazet
2012-10-19 9:26 ` David Laight
2012-10-19 17:12 ` David Miller
2012-10-18 19:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350552612.26103.1281.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox