RE: sock_getsockopt() not exported

[Eric Dumazet <eric.dumazet@gmail.com>]

On Thu, 2012-10-18 at 13:03 +0100, David Laight wrote:
> > On Thu, 2012-10-18 at 10:11 +0100, David Laight wrote:
> > > I've noticed that net/core/sock.c contains an
> > >     EXPORT_SYMBOL(sock_setsockopt)
> > > but is missing the corresponding
> > >     EXPORT_SYMBOL(sock_getsockopt)
> > >
> > > In-kernel users of sockets probably manage without
> > > needing to read SOL_SOCKET options.
> > > (They do need to set SO_REUSADDR and SO_KEEPALIVE.)
> > 
> > sock_setsockopt() is exported because sunrpc needs it, and sunrpc can be
> > a module
> > 
> > sock_getsockopt() is not exported because no module needs it yet.
> > 
> > The day one user needs it, we'll add the EXPORT_SYMBOL()
> 
> The problem is that it might be needed by an 'out of tree' driver.
> We already have the function:

We dont care of out of tree drivers.

Thats really simple.

Submit this driver, and add the EXPORT_SYMBOL() you need at that time.