[PATCH net] tcp: Fix double sizeof in new tcp_metrics code

[PATCH net] tcp: Fix double sizeof in new tcp_metrics code

[Julian Anastasov]

	Fix double sizeof when parsing IPv6 address from
user space because it breaks get/del by specific IPv6 address.

	Problem noticed by David Binderman:

https://bugzilla.kernel.org/show_bug.cgi?id=49171

Signed-off-by: Julian Anastasov <ja@ssi.bg>
---
 net/ipv4/tcp_metrics.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c
index 4c752a6..53bc584 100644
--- a/net/ipv4/tcp_metrics.c
+++ b/net/ipv4/tcp_metrics.c
@@ -864,7 +864,7 @@ static int parse_nl_addr(struct genl_info *info, struct inetpeer_addr *addr,
 	}
 	a = info->attrs[TCP_METRICS_ATTR_ADDR_IPV6];
 	if (a) {
-		if (nla_len(a) != sizeof(sizeof(struct in6_addr)))
+		if (nla_len(a) != sizeof(struct in6_addr))
 			return -EINVAL;
 		addr->family = AF_INET6;
 		memcpy(addr->addr.a6, nla_data(a), sizeof(addr->addr.a6));
-- 
1.7.3.4

Re: [PATCH net] tcp: Fix double sizeof in new tcp_metrics code

[David Miller]

From: Julian Anastasov <ja@ssi.bg>
Date: Wed, 31 Oct 2012 00:03:09 +0200

> 	Fix double sizeof when parsing IPv6 address from
> user space because it breaks get/del by specific IPv6 address.
> 
> 	Problem noticed by David Binderman:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=49171
> 
> Signed-off-by: Julian Anastasov <ja@ssi.bg>

Applied, thanks.