From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Jones <davej@redhat.com>
Cc: Julius Werner <jwerner@chromium.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Patrick McHardy <kaber@trash.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
James Morris <jmorris@namei.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"David S. Miller" <davem@davemloft.net>,
Sameer Nanda <snanda@chromium.org>,
Mandeep Singh Baines <msb@chromium.org>,
Eric Dumazet <edumazet@chromium.org>
Subject: Re: [PATCH] tcp: Replace infinite loop on recvmsg bug with proper crashusers
Date: Wed, 07 Nov 2012 08:29:12 -0800 [thread overview]
Message-ID: <1352305752.3140.4449.camel@edumazet-glaptop> (raw)
In-Reply-To: <20121107155434.GA17677@redhat.com>
On Wed, 2012-11-07 at 10:54 -0500, Dave Jones wrote:
> It sounds more appropriate to me, instead of silently wedging the box.
> At least with that approach we have a chance of finding out what happened.
Its quite the opposite.
If bug is still there 6 months after the commits that broke the drivers,
(making an old bug visible) that means that people never realized the
bug was there.
I understand a distro maintainer has its own choices, but for upstream
kernel we want to have early reports.
This bug is fatal and a security issue. BUG() is appropriate.
If the driver cant be fixed, it should be marked broken.
So I personally NACKed patch to hide the bug, trying to be friendly to
the user.
next prev parent reply other threads:[~2012-11-07 16:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 0:15 [PATCH] tcp: Replace infinite loop on recvmsg bug with proper crash Julius Werner
2012-11-07 1:39 ` Dave Jones
2012-11-07 1:51 ` Julius Werner
2012-11-07 15:54 ` Dave Jones
2012-11-07 16:29 ` Eric Dumazet [this message]
2012-11-07 16:43 ` [PATCH] tcp: Replace infinite loop on recvmsg bug with proper crashusers Dave Jones
2012-11-07 17:05 ` Eric Dumazet
2012-11-07 17:15 ` Dave Jones
2012-11-07 19:32 ` Julius Werner
2012-11-07 19:33 ` [PATCH] tcp: Avoid infinite loop on recvmsg bug Julius Werner
2012-11-07 19:40 ` Eric Dumazet
2012-11-07 21:14 ` Julius Werner
2012-11-07 23:33 ` Eric Dumazet
2012-11-07 23:42 ` Eric Dumazet
2012-11-08 2:25 ` Julius Werner
2012-11-09 3:29 ` Eric Dumazet
2012-12-10 19:33 ` Julius Werner
2012-12-10 20:23 ` David Miller
2012-11-07 1:51 ` [PATCH] tcp: Replace infinite loop on recvmsg bug with proper crash Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352305752.3140.4449.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@chromium.org \
--cc=jmorris@namei.org \
--cc=jwerner@chromium.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=snanda@chromium.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox