Netdev List
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: <netdev@vger.kernel.org>
Subject: Re: question on netdev_completed_queue()
Date: Thu, 8 Nov 2012 20:44:13 +0000	[thread overview]
Message-ID: <1352407453.2771.18.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <1476426.QTHA7ibVHZ@linux-lqwf.site>

On Thu, 2012-11-08 at 20:38 +0100, Oliver Neukum wrote:
> Hi,
> 
> is this function to be called whenever a driver is done with transmitting
> data, whether the transmission be successful or not?

Yes, BQL tracks number of packets and bytes in each queue and you have
to tell it about all insertions and removals from the queue.  (Except
that if you flush the queue, you can use netdev_reset_queue() rather
than trying to counting the remaining packets and bytes.)

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  reply	other threads:[~2012-11-08 20:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08 19:38 question on netdev_completed_queue() Oliver Neukum
2012-11-08 20:44 ` Ben Hutchings [this message]
2012-11-09 16:58   ` Oliver Neukum
2012-11-09 17:09     ` Ben Hutchings
2012-11-09 19:38       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352407453.2771.18.camel@bwh-desktop.uk.solarflarecom.com \
    --to=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox