Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Oliver Neukum <oliver@neukum.org>, netdev@vger.kernel.org
Subject: Re: question on netdev_completed_queue()
Date: Fri, 09 Nov 2012 11:38:30 -0800	[thread overview]
Message-ID: <1352489910.19779.770.camel@edumazet-glaptop> (raw)
In-Reply-To: <1352480979.3159.13.camel@bwh-desktop.uk.solarflarecom.com>

On Fri, 2012-11-09 at 17:09 +0000, Ben Hutchings wrote:

> The underlying DQL algorithm doesn't care what it's counting.  However
> the administrator can adjust the queue limits through sysfs, and they
> will expect the numbers to be byte counts.

Yes, skb->len should be a fine approximation, even if slightly wrong for
TSO packets.

      reply	other threads:[~2012-11-09 19:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08 19:38 question on netdev_completed_queue() Oliver Neukum
2012-11-08 20:44 ` Ben Hutchings
2012-11-09 16:58   ` Oliver Neukum
2012-11-09 17:09     ` Ben Hutchings
2012-11-09 19:38       ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352489910.19779.770.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox