From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Vijay Subramanian <subramanian.vijay@gmail.com>,
David Miller <davem@davemloft.net>,
saku@ytti.fi, rick.jones2@hp.com, netdev@vger.kernel.org
Subject: Re: TCP and reordering
Date: Wed, 28 Nov 2012 04:52:20 -0800 [thread overview]
Message-ID: <1354107140.14302.140.camel@edumazet-glaptop> (raw)
In-Reply-To: <1354106362.21562.51.camel@shinybook.infradead.org>
On Wed, 2012-11-28 at 12:39 +0000, David Woodhouse wrote:
>
> I'll go back to looking at TSQ, and BQL for PPP. If I have to use
> skb_orphan() and install a destructor of my own in order to do BQL for
> PPP, that'll upset TSQ a little. Is there a way we could *chain* the
> destructors... skb_clone() to put the skbs on the PPP channels' queues,
> perhaps, then free the original from the PPP destructor? Or is that too
> much overhead?
>
> I've killed most of the channel queue for PPPoATM and PPPoE now, but
> L2TP still has a whole load of buffering all the way through the stack
> again before it really leaves the host.
>
> (And PPPoE will still have the txqueuelen on the Ethernet device too).
>
BQL is nice for high speed adapters.
For slow one, you always can stop the queue for each packet given to
start_xmit()
And restart the queue at TX completion.
Some device drivers do that (because the hardware has a single slot, no
ring buffer, not because they wanted to fight bufferbloat ;) )
next prev parent reply other threads:[~2012-11-28 12:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 9:32 TCP and reordering Saku Ytti
2012-11-27 17:05 ` Rick Jones
2012-11-27 17:15 ` Saku Ytti
2012-11-27 18:00 ` Rick Jones
2012-11-28 2:06 ` David Miller
2012-11-28 7:26 ` Saku Ytti
2012-11-28 8:35 ` Vijay Subramanian
2012-11-28 8:54 ` Saku Ytti
2012-11-28 18:24 ` Rick Jones
2012-11-28 18:33 ` Eric Dumazet
2012-11-28 18:52 ` Vijay Subramanian
2012-11-28 18:44 ` Saku Ytti
2012-11-28 7:59 ` David Woodhouse
2012-11-28 8:21 ` Christoph Paasch
2012-11-28 8:22 ` Vijay Subramanian
2012-11-28 9:08 ` David Woodhouse
2012-11-28 11:02 ` Eric Dumazet
2012-11-28 11:49 ` David Woodhouse
2012-11-28 12:26 ` Eric Dumazet
2012-11-28 12:39 ` David Woodhouse
2012-11-28 12:52 ` Eric Dumazet [this message]
2012-11-28 15:47 ` David Woodhouse
2012-11-28 16:09 ` Eric Dumazet
2012-11-28 16:21 ` David Woodhouse
2012-11-28 16:19 ` Benjamin LaHaise
2012-11-28 16:41 ` David Woodhouse
2012-11-28 17:08 ` Benjamin LaHaise
2012-11-28 17:16 ` Eric Dumazet
2012-11-28 18:01 ` David Woodhouse
2012-11-29 15:10 ` Noel Grandin
2012-12-02 1:30 ` David Woodhouse
2012-12-02 2:40 ` Eric Dumazet
2012-12-02 9:31 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354107140.14302.140.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=saku@ytti.fi \
--cc=subramanian.vijay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox