From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Vasanthakumar Thiagarajan
<vthiagar-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up
Date: Thu, 06 Dec 2012 21:38:55 -0800 [thread overview]
Message-ID: <1354858735.22463.31.camel@joe-AO722> (raw)
In-Reply-To: <1354853850-10537-1-git-send-email-vthiagar-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
On Fri, 2012-12-07 at 09:47 +0530, Vasanthakumar Thiagarajan wrote:
> struct mac_address will be used by ACL related configuration ops.
I'd prefer that any new code _not_ use struct mac_address
but use u8 addr[ETH_ALEN] instead.
That's the most common style in the kernel.
$ git grep -E "\bu8\s+\w+\s*\[\s*ETH_ALEN\s*\]" | wc -l
749
$ git grep -E "\bstruct\s+mac_address\b" | wc -l
13
There are also uses of char and unsigned char
$ git grep -E "\bchar\s+\w+\s*\[\s*ETH_ALEN\s*\]" | wc -l
121
Some of those are ancient, but it'd be good to
be consistent throughout the kernel.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2012-12-07 5:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1354853850-10537-1-git-send-email-vthiagar@qca.qualcomm.com>
[not found] ` <1354853850-10537-1-git-send-email-vthiagar-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
2012-12-07 5:38 ` Joe Perches [this message]
2012-12-07 6:56 ` [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up Vasanthakumar Thiagarajan
2012-12-07 8:09 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354858735.22463.31.camel@joe-AO722 \
--to=joe-6d6dil74uinbdgjk7y7tuq@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vthiagar-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox