From: Eric Dumazet <erdnetdev@gmail.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
annie li <annie.li@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xen/netfront: improve truesize tracking
Date: Wed, 19 Dec 2012 08:17:49 -0800 [thread overview]
Message-ID: <1355933869.21834.13.camel@edumazet-glaptop> (raw)
In-Reply-To: <55633610.20121219123427@eikelenboom.it>
On Wed, 2012-12-19 at 12:34 +0100, Sander Eikelenboom wrote:
> Hi Ian,
>
> It ran overnight and i haven't seen the warn_once trigger.
> (but i also didn't with the previous patch)
>
As I said, the miminum value to not trigger the warning was what Ian
patch was doing, but it was still a not accurate estimation.
Doing the real accounting might trigger slow transferts, or dropped
packets because of socket limits (SNDBUF / RCVBUF) being hit sooner.
So the real question was : If accounting for full pages, is your
applications run as smooth as before, with no huge performance
regression ?
next prev parent reply other threads:[~2012-12-19 16:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 13:51 [PATCH] xen/netfront: improve truesize tracking Ian Campbell
2012-12-18 14:10 ` Konrad Rzeszutek Wilk
2012-12-18 14:15 ` Ian Campbell
2012-12-18 15:12 ` Eric Dumazet
2012-12-18 15:26 ` Ian Campbell
2012-12-18 16:13 ` Eric Dumazet
2012-12-18 16:22 ` Ian Campbell
2012-12-18 16:35 ` Eric Dumazet
2012-12-19 11:34 ` Sander Eikelenboom
2012-12-19 16:17 ` Eric Dumazet [this message]
2012-12-20 12:51 ` Sander Eikelenboom
2012-12-20 14:23 ` [Xen-devel] " Sander Eikelenboom
2012-12-20 14:58 ` Sander Eikelenboom
2012-12-20 15:39 ` Eric Dumazet
2012-12-21 11:21 ` Sander Eikelenboom
2012-12-21 18:33 ` Rick Jones
2013-01-03 20:40 ` Sander Eikelenboom
2013-01-07 13:41 ` Ian Campbell
2013-01-07 14:11 ` Sander Eikelenboom
2013-01-07 14:22 ` Ian Campbell
2013-01-07 15:26 ` Eric Dumazet
2013-01-07 16:17 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355933869.21834.13.camel@edumazet-glaptop \
--to=erdnetdev@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox