From: Eric Dumazet <erdnetdev@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, Sedat Dilek <sedat.dilek@gmail.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Julian Anastasov <ja@ssi.bg>
Subject: Re: [Patch v2] arp: fix a regression in arp_solicit()
Date: Mon, 24 Dec 2012 08:41:14 -0800 [thread overview]
Message-ID: <1356367274.20133.9176.camel@edumazet-glaptop> (raw)
In-Reply-To: <1356312196-23185-1-git-send-email-xiyou.wangcong@gmail.com>
On Mon, 2012-12-24 at 09:23 +0800, Cong Wang wrote:
> From: Cong Wang <xiyou.wangcong@gmail.com>
>
> Sedat reported the following commit caused a regression:
>
> commit 9650388b5c56578fdccc79c57a8c82fb92b8e7f1
> Author: Eric Dumazet <edumazet@google.com>
> Date: Fri Dec 21 07:32:10 2012 +0000
>
> ipv4: arp: fix a lockdep splat in arp_solicit
>
> This is due to the 6th parameter of arp_send() needs to be NULL
> for the broadcast case, the above commit changed it to an all-zero
> array by mistake.
>
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Cc: Sedat Dilek <sedat.dilek@gmail.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>
> ---
Oops, thanks for fixing this.
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2012-12-24 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 1:23 [Patch v2] arp: fix a regression in arp_solicit() Cong Wang
2012-12-24 16:41 ` Eric Dumazet [this message]
2012-12-25 2:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356367274.20133.9176.camel@edumazet-glaptop \
--to=erdnetdev@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox