* [PATCH net-next/master] ethernet/broadcom/tg3: Fix sparse warning: constant 0x7fffffffffffffff is so big it is long long [not found] <50beaf6a.HF5L0P4z6BqrUx/x%fengguang.wu@intel.com> @ 2013-01-03 14:23 ` Peter Huewe 2013-01-04 23:11 ` David Miller 0 siblings, 1 reply; 2+ messages in thread From: Peter Huewe @ 2013-01-03 14:23 UTC (permalink / raw) To: Matt Carlson Cc: Nithin Nayak Sujir, Michael Chan, netdev, linux-kernel, Fengguang Wu, kbuild, Peter Huewe Sparse complains that: drivers/net/ethernet/broadcom/tg3.c:5670:55: sparse: constant 0x7fffffffffffffff is so big it is long long (on x86/32 bit) so we suffix the constant with LL in the header file. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- drivers/net/ethernet/broadcom/tg3.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h index d330e81..247d954 100644 --- a/drivers/net/ethernet/broadcom/tg3.h +++ b/drivers/net/ethernet/broadcom/tg3.h @@ -774,7 +774,7 @@ #define SG_DIG_AUTONEG_ERROR 0x00000001 #define TG3_TX_TSTAMP_LSB 0x000005c0 #define TG3_TX_TSTAMP_MSB 0x000005c4 -#define TG3_TSTAMP_MASK 0x7fffffffffffffff +#define TG3_TSTAMP_MASK 0x7fffffffffffffffLL /* 0x5c8 --> 0x600 unused */ #define MAC_TX_MAC_STATE_BASE 0x00000600 /* 16 bytes */ #define MAC_RX_MAC_STATE_BASE 0x00000610 /* 20 bytes */ -- 1.7.8.6 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next/master] ethernet/broadcom/tg3: Fix sparse warning: constant 0x7fffffffffffffff is so big it is long long 2013-01-03 14:23 ` [PATCH net-next/master] ethernet/broadcom/tg3: Fix sparse warning: constant 0x7fffffffffffffff is so big it is long long Peter Huewe @ 2013-01-04 23:11 ` David Miller 0 siblings, 0 replies; 2+ messages in thread From: David Miller @ 2013-01-04 23:11 UTC (permalink / raw) To: peterhuewe Cc: mcarlson, nsujir, mchan, netdev, linux-kernel, fengguang.wu, kbuild From: Peter Huewe <peterhuewe@gmx.de> Date: Thu, 3 Jan 2013 15:23:50 +0100 > Sparse complains that: > drivers/net/ethernet/broadcom/tg3.c:5670:55: sparse: constant > 0x7fffffffffffffff is so big it is long long (on x86/32 bit) > > so we suffix the constant with LL in the header file. > > Reported-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Applied. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-04 23:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50beaf6a.HF5L0P4z6BqrUx/x%fengguang.wu@intel.com>
2013-01-03 14:23 ` [PATCH net-next/master] ethernet/broadcom/tg3: Fix sparse warning: constant 0x7fffffffffffffff is so big it is long long Peter Huewe
2013-01-04 23:11 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox