From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: christoph.paasch@uclouvain.be,
Ian Campbell <Ian.Campbell@citrix.com>,
Sony Chacko <sony.chacko@qlogic.com>,
Rajesh Borundia <rajesh.borundia@qlogic.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: BUG in netxen_release_tx_buffers when TSO enabled on kernels >= 3.3 and <= 3.6
Date: Tue, 22 Jan 2013 11:59:42 -0800 [thread overview]
Message-ID: <1358884782.12374.8.camel@edumazet-glaptop> (raw)
In-Reply-To: <1358883411.2892.11.camel@bwh-desktop.uk.solarflarecom.com>
On Tue, 2013-01-22 at 19:36 +0000, Ben Hutchings wrote:
> There's another bug right here, which is that 0 is a valid DMA address
> in some systems. The driver should be calling pci_dma_mapping_error()
> to find out whether an address is valid or not. But it also wants to be
> able to assign an invalid address to netxen_skb_frag::dma, and
> unfortunately there is no way to do that in the current DMA API.
>
I guess we should only test ->frag_count then, and set it to 0 in TX
completion path.
next prev parent reply other threads:[~2013-01-22 19:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 10:15 BUG in netxen_release_tx_buffers when TSO enabled on kernels >= 3.3 and <= 3.6 Christoph Paasch
2013-01-22 13:32 ` Eric Dumazet
2013-01-22 13:56 ` Eric Dumazet
2013-01-22 15:03 ` Christoph Paasch
2013-01-22 15:43 ` Christoph Paasch
2013-01-22 16:33 ` Eric Dumazet
2013-01-22 16:55 ` Christoph Paasch
2013-01-22 18:46 ` Rajesh Borundia
2013-01-22 19:15 ` David Miller
2013-01-22 19:36 ` Ben Hutchings
2013-01-22 19:59 ` Eric Dumazet [this message]
2013-01-23 19:47 ` Rajesh Borundia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358884782.12374.8.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=bhutchings@solarflare.com \
--cc=christoph.paasch@uclouvain.be \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox