From: Christoph Paasch <christoph.paasch@uclouvain.be>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
Sony Chacko <sony.chacko@qlogic.com>,
Rajesh Borundia <rajesh.borundia@qlogic.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: BUG in netxen_release_tx_buffers when TSO enabled on kernels >= 3.3 and <= 3.6
Date: Tue, 22 Jan 2013 16:03:59 +0100 [thread overview]
Message-ID: <2166577.r0iRQtU7qE@cpaasch-mac> (raw)
In-Reply-To: <1358862966.3464.3797.camel@edumazet-glaptop>
On Tuesday 22 January 2013 05:56:06 Eric Dumazet wrote:
> I guess netxen driver has a bug.
>
> Please try the following patch :
>
> diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c index
> bc165f4..695667d 100644
> --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> @@ -144,7 +144,7 @@ void netxen_release_tx_buffers(struct netxen_adapter
> *adapter) buffrag->length, PCI_DMA_TODEVICE); buffrag->dma = 0ULL;
> }
> - for (j = 0; j < cmd_buf->frag_count; j++) {
> + for (j = 1; j < cmd_buf->frag_count; j++) {
> buffrag++;
> if (buffrag->dma) {
> pci_unmap_page(adapter->pdev, buffrag->dma,
Perfect, I tested it, and this fixes the bug.
I should have found it on my own, I have been starring for too long at this
function... :)
Feel free to add
Tested-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Thanks, Eric!
Christoph
--
IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://mptcp.info.ucl.ac.be
UCLouvain
--
next prev parent reply other threads:[~2013-01-22 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 10:15 BUG in netxen_release_tx_buffers when TSO enabled on kernels >= 3.3 and <= 3.6 Christoph Paasch
2013-01-22 13:32 ` Eric Dumazet
2013-01-22 13:56 ` Eric Dumazet
2013-01-22 15:03 ` Christoph Paasch [this message]
2013-01-22 15:43 ` Christoph Paasch
2013-01-22 16:33 ` Eric Dumazet
2013-01-22 16:55 ` Christoph Paasch
2013-01-22 18:46 ` Rajesh Borundia
2013-01-22 19:15 ` David Miller
2013-01-22 19:36 ` Ben Hutchings
2013-01-22 19:59 ` Eric Dumazet
2013-01-23 19:47 ` Rajesh Borundia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2166577.r0iRQtU7qE@cpaasch-mac \
--to=christoph.paasch@uclouvain.be \
--cc=Ian.Campbell@citrix.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox